Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, ccruz, deshani, and 11 others

#4115 Highlight selected row when viewing file

Milestone: v1.0.0

Status: closed

Owner: nobody

Labels: 42cc (432)

Component: General

Reviewer: Dave Brondsema

Updated: 2015-08-20

Created: 2012-04-26

Creator: Dave Brondsema

Private: No

When you click on a row - it should be highlighted (like on github). Even better to have each line of a text as a hyper link (we could create a link for a line number at the left), so I'd be able to copy&paste it somewhere. E.g. we're discussing some part of the code and I want to put a link to some line in the code into a ticket comment.

Discussion

Anonymous - 2012-04-30

Originally by: tramadolmen

In taskd logs i get

OperationFailure: command SON([('findAndModify', u'monq_task'), ('sort', [('priority', -1), ('time_queue', 1)]), ('query', {'state': 'ready'}), ('update', {'$set': {'process': 'userdevice pid 3370', 'state': 'busy'}}), ('new', True)]) failed: no such cmd

Can you explain what's wrong with taskd and how i can fix this?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2012-04-30

What version of mongo do you have? I think 1.8 is the minimum required.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2012-04-30

Originally by: tramadolmen

I have 1.2.2 version. After installation version 2.0.4 all errors are gone from taskd.log

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Yaroslav Luzin - 2012-05-03

Closed #21 and pushed changes into 42cc_4115

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2012-05-03

status: open --> code-review

qa: ᗫave ᙖrondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2012-05-03

status: code-review --> open
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2012-05-03

I'd like to see test coverage for this. The functional tests of ForgeGit, ForgeHg, and ForgeSVN probably do run this code, but those are broad tests and don't test LineAnchorCodeHtmlFormatter precisely. Can we have a unit test for LineAnchorCodeHtmlFormatter?

codeline_ is a big long for my preference. What do you think about using l or L for the prefix? That is what gitweb and trac do.

Last, I'd prefer to not change the text color of the line (it gets set to light blue). The line number can be styled, but we shouldn't change any coloring of the text.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Yaroslav Luzin - 2012-05-04

Yes, I also like to use l or L instead of codeline_

Created a ticket #47: [4115] Highlight selected row - write a test, small amendments and a little refactoring (1cp).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Yaroslav Luzin - 2012-05-04

Closed #47 and pushed changes back into 42cc_4115

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2012-05-04

status: open --> closed

milestone: forge-backlog --> forge-may-18
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.