Apache Allura™ / Tickets / #4153 RSS feed for blog not showing revisions or deleted posts

Dave Brondsema - 2013-07-11

Milestone: limbo --> forge-backlog
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2013-08-12

Originally by: martinprikryl

I also suffer from this bug. Any news on this?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2013-12-19

Originally by: martinprikryl

Bump. Any news on this? It's really a pain not to be able to amend RSS feed contents.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pranav Sharma - 2016-01-29

I'm not able to find the code where the creation of blog post also makes the entry into the rss feeds.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pranav Sharma - 2016-01-31

Description has changed:

Diff:

status: open --> in-progress

assigned_to: Pranav Sharma

Reviewer: Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pranav Sharma - 2016-01-31

@Dave, I made a change, and it seems to work..

https://forge-allura.apache.org/u/pranav/allura/ci/7bf41606e782c2a4a9387f4880d5ea8607df7ed8/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-02-05

Glad you found the spot. This does work to some extent, but it creates new entries for each revision. I am not sure if that's what we want or not. It lets people subscribed to the feed see all the changes to a blog post, and in some cases that might be useful but I think in most cases people just want the final version in the feed. They don't want people to see the earlier versions.

To do that, I think the Feed.post method will have to be refactored so to create a new Feed.update method. Set it up so that most of the logic for the permission checks and values are shared (perhaps with a new helper method). And then post would create a new item and update would update an existing one (fetch it with the "ref_id" field probably). Then in the blog code, you can call Feed.post for new items and Feed.update for existing ones.

Also, if you save something as a draft, and then edit it and keep it as a draft, it is posted to the rss feed but it should never do that if its a draft.

And an additional thing is that the original description requests that the feed items are removed if a blog post is deleted.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Pranav Sharma - 2016-02-14
  
  @Dave, review the branch pr/4153. I made update function for the chenge. It seems to work as desired.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-02-18

A better way to write if Feed.has_access(artifact) == False: is if not Feed.has_access(artifact). Checking for False explicitly isn't normally needed (and when you do, people typically use is False instead of == False).

Updating is looking just right.

Can you delete the Feed item if the post status changes to "draft", or is deleted?

Thanks.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Dave Brondsema - 2016-03-07
  
  Any updates on this ticket? I think you're pretty close to having it complete.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-03-14

status: in-progress --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-03-14

Hey Pranav,

I was doing a little more testing and noticed that if you delete a blog post, it doesn't remove it from the RSS feed. Would you like to look into that? I think we overlooked that since we were focusing mostly on editing and changing the status of a blog post.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Dave Brondsema - 2016-03-24
  
  Thanks, merged https://forge-allura.apache.org/u/pranav/allura/ci/fd92c8acd2438ddb288c5313ceda40259acda122/
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-04-11

Milestone: unreleased --> v1.4.0
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Apache Allura™

Forge software for hosting software projects

Milestone

Searches

Help

#4153 RSS feed for blog not showing revisions or deleted posts

Related

Discussion