Right now we display the latest 100 activities in the timeline. This is probably an acceptable default for now, but we should at least have a way to page back through older activities.
--- old+++ new@@ -1 +1,3 @@
For better memory usage and performance, the activity stream create_timeline() method should accept a timedelta parameter (default to 1 week or 1 month) and pass that through to its queries.
++Maybe start/end timestamps instead of a timedelta.
size: --> 2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
summary: Activity stream time span parameter --> Activitystream timeline limit and pagination
Description has changed:
Diff:
--- old+++ new@@ -1,3 +1,2 @@-For better memory usage and performance, the activity stream create_timeline() method should accept a timedelta parameter (default to 1 week or 1 month) and pass that through to its queries.+Right now we display the latest 100 activities in the timeline. This is probably an acceptable default for now, but we should at least have a way to page back through older activities.-Maybe start/end timestamps instead of a timedelta.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Memory-managed infinite scroll enabled by default. Show More paging and standard paging also supported. Falls back to standard paging if PJAX / HTML5 history API not supported or if javascript is not enabled.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Diff:
Diff:
allura:cj/4257Memory-managed infinite scroll enabled by default. Show More paging and standard paging also supported. Falls back to standard paging if PJAX / HTML5 history API not supported or if javascript is not enabled.
Overall this looks great, nice work. I did find a few minor issues:
allura:cj/4257I'm not happy with the work-around for IE11 but it works until we can look into the possibility of upgrading jQuery.