#4347 Validation for blog rss feed

v1.0.0
closed
nobody
42cc (432)
General
Cory Johns
2015-08-20
2012-06-11
Dave Brondsema
No

We got this error when running against some invalid data in prod:

  File "/var/local/allura/ForgeBlog/forgeblog/command/rssfeeds.py", line 134, in command
    self.process_feed(appid, feed_url)
  File "/var/local/allura/ForgeBlog/forgeblog/command/rssfeeds.py", line 163, in process_feed
    base.log.exception("%s: %s" % (feed_url, f.bozo_exception))
AttributeError: 'module' object has no attribute 'log'

Let's make several improvements:

  1. fix the logging line to not throw the error
  2. add URL validation on the input field
  3. improve the input form UI: put a label in front of the text field that says "Add RSS/Atom feed URL"

Related

Tickets: #4347

Discussion

  • Yaroslav Luzin - 2012-06-13
    • status: open --> in-progress
     

  • Yaroslav Luzin - 2012-06-13

    created #82: [#4347] Validation for blog rss feed (1cp)

     

    Related

    Tickets: #4347

  • Yaroslav Luzin - 2012-06-19
    • status: in-progress --> code-review
     

  • Yaroslav Luzin - 2012-06-19

    pushed changes into 42cc_4347, closed #82

     

  • Cory Johns - 2012-06-22
    • status: code-review --> closed
    • qa: Cory Johns
    • milestone: forge-backlog --> forge-jun-29
     

Log in to post a comment.