#4510 Don't show Edit link / form on ticket comments if not allowed to edit

v1.0.0
closed
nobody
42cc (432)
Tracker
Cory Johns
2015-08-20
2012-07-09
Cory Johns
No

Editing other users' comments on Tracker tickets requires the MODERATE permission. However, the Edit link and form are shown on the ticket comments even if you do not have that permission, although the edit is rejected when submitted.

The link and form should not be available if the user does not have permission to edit that comment. (May need to verify whether a user should be able to edit their own comments.)

Related

Tickets: #4510

Discussion

  • Dave Brondsema

    Dave Brondsema - 2012-07-09
    • labels: --> 42cc
     
  • Yaroslav Luzin - 2012-07-10
    • status: open --> in-progress
     
  • Yaroslav Luzin - 2012-07-10

    created #108: [#4510] Don't show Edit link / form on ticket comments if not allowed to edit (1cp)

     

    Related

    Tickets: #4510

  • Yaroslav Luzin - 2012-07-11

    closed #108, see 42cc_4510

    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2012-07-11
    • qa: Cory Johns
     
  • Cory Johns - 2012-07-16
    • status: code-review --> open
     
  • Cory Johns - 2012-07-16

    A user should be able to edit their own tickets still, even if they don't have MODERATE permission.

     
  • Yaroslav Luzin - 2012-07-17

    Cory, please confirm that a user can not edit their own comments. We check for the MODERATE permission only, but seems that it's set for the owners. I tried with 3 different users on our staging server, and when a user did not have the moderate permission he still could edit his own comments.

    • status: open --> code-review
     
  • Cory Johns - 2012-07-17

    Ok, I didn't realize that having UNMODERATED_POST also gives MODERATE on one's own comments, but that is in fact the case. This means that users can't edit their own comments if moderation is required, but that's good anyway since I doubt edits go through moderation (currently).

    Closing as it is good.

    • status: code-review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2012-07-18
    • milestone: forge-backlog --> forge-jul-27
     

Log in to post a comment.