If we think about my_projects more broadly than the user page, are there any cases we want to include deleted projects? I grepped for my_projects and don't see any cases that would make sense. In fact, all the other uses of my_projects should omit deleted projects too. So let's make that only way it works, rather than the exclude_deleted flag.
There's no test for this either. I know it's a trivial change, but adding it into the existing test of my_projects shouldn't be too hard either.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
created #111: [#4528] Filter for deleted projects on user profile page (1cp)
Related
Tickets:
#4528closed #111, see 42cc_4528 branch
If we think about
my_projects
more broadly than the user page, are there any cases we want to include deleted projects? I grepped formy_projects
and don't see any cases that would make sense. In fact, all the other uses ofmy_projects
should omit deleted projects too. So let's make that only way it works, rather than the exclude_deleted flag.There's no test for this either. I know it's a trivial change, but adding it into the existing test of my_projects shouldn't be too hard either.
created #120: [#4528] Omit deleted projects in my_projects and write a test (1cp)
Related
Tickets:
#4528closed #120, please check the 42cc_4528 branch