#4571 Add caching headers to images & docs served from allura

v1.0.0
closed
Dave Brondsema
performance (126) sf-2 (994)
General
Cory Johns
2015-08-20
2012-07-17
Dave Brondsema
No

Attachments, icons, screenshots, etc should all be cachable. For all of those, we should change the no-cache headers to reasonable caching headers. We should remove the Set-cookie header (I think), to make it more cacheable. We should set a Last-Modified header based on the file's last date. Since these images & documents can be updated, we shouldn't specify aggressive caching. Perhaps just omit the caching directives altogether?

Discussion

  • Dave Brondsema

    Dave Brondsema - 2012-10-09
    • labels: --> performance
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
    • size: --> 2
    • milestone: forge-backlog --> forge-oct-19
     

  • Dave Brondsema

    Dave Brondsema - 2012-10-09

    forge:db/4571

    • run curl -I against a project icon. Ensure that caching headers are good, no set-cookie header
    • clear cookies, login, and submit a form and make sure CSRF doesn't erroneously stop you
    • upload an icon and make sure that the new version shows up immediately
     

  • Dave Brondsema

    Dave Brondsema - 2012-10-09
    • status: in-progress --> code-review
    • qa: Cory Johns
     

  • Cory Johns - 2012-10-09
    • status: code-review --> closed
     

Log in to post a comment.