#4723 Don't link to user-project when Anonymous

v1.1.0
closed
nobody
42cc (432)
User
Tim Van Steenburgh
2015-08-20
2012-08-15
Dave Brondsema
No

Links go to "/u/userid-None/" which 404s of course. They used to go to "/u/*anonymous/" but that 404s too.

We shouldn't provide links if the user is anonymous. Comments is a common place for this to occur, but also need to look out for ticket creators/assigned-to and wiki contributors, probably many more.

Related

Tickets: #3566

Discussion

  • Dave Brondsema

    Dave Brondsema - 2012-08-15
    • assigned_to: Jenny Steele --> nobody
    • size: 1 --> 0
     

  • Dave Brondsema

    Dave Brondsema - 2013-11-06
    • Labels: --> 42cc
    • Status: open --> in-progress
     

  • Igor Bondarenko - 2013-11-20
    • status: in-progress --> code-review
     

  • Igor Bondarenko - 2013-11-20

    Closed #487. je/42cc_4723

     

  • Tim Van Steenburgh - 2013-11-20
    • QA: Tim Van Steenburgh
    • Milestone: forge-backlog --> forge-nov-29
     

  • Tim Van Steenburgh - 2013-11-20
    • status: code-review --> in-progress
     

  • Tim Van Steenburgh - 2013-11-20

    Since this little pattern is repeated so often (render username, with href, but only if not anonymous), it would be great to see it rolled up into a macro. Unfortunately user_link() is already taken, but one idea is to rename that to email_link() (doesn't look like it's used in very many places), and create a user_link(user, avatar=False, size=16) macro. If avatar=True, call lib.gravatar_or_name(), otherwise just use display_name.

     

  • Igor Bondarenko - 2013-11-27
    • status: in-progress --> code-review
     

  • Igor Bondarenko - 2013-11-27

    Closed #500. Rebased and force-pushed je/42cc_4723

     

  • Tim Van Steenburgh - 2013-11-27
    • status: code-review --> closed
     

Log in to post a comment.