#5538 Show invalid links as plain text after markdownification

v1.0.0
closed
nobody
42cc (432)
General
Cory Johns
2015-08-20
2013-01-02
Anonymous
No

Originally created by: vampire0

I just created [forge:feature-requests:#43] and it rendered [18:13:49] as a link to https://sourceforge.net/p/forge/feature-requests/ and @ctsai-sf as a mailto: link. Both is wrong, as [18:13:49] is no valid artifact link and thus should be shown as plain text and @ctsai-sf is no valid email address and thus should be shown as plain text.

Related

Tickets: #5538

Discussion

  • Anonymous - 2013-01-02

    Originally by: vampire0

    Interestingly enough, the timestamp is also rendered as link to this ticket tool here, but @ctsai-sf is not rendered as mailto: link, is this a separate bug?

     
  • Dave Brondsema

    Dave Brondsema - 2013-01-02
    • milestone: limbo --> forge-backlog
     
  • Dave Brondsema

    Dave Brondsema - 2013-01-02

    @ctsai-sf isn't a valid email address. Moreover email addresses aren't auto-linked, you have to use <foo@bar.com>

     
  • Dave Brondsema

    Dave Brondsema - 2013-01-02

    I think it used to work like this. I'm thinking it's regression bug from markdown upgrades and related artifact reference parsing changes a few months ago.

     
  • Anonymous - 2013-01-03

    Originally by: vampire0

    Ah, right, when copying from XChat it copied the username in angle brackets so it was \<@ctsai-sf> which was copied in and made a mailto: link, that is the cause it was no mailto: link in the description of this issue. Actually I see now that my username is missing completely which was \<vampire> and which gets transformed to just nothing. So if between \< and > no valid email address is written, it should be shown as plain text including the angle brackets.</vampire>

     
  • Anonymous - 2013-01-03

    Originally by: vampire0

    Hm, shouldn't the backslash escape the angle brackets and disappear on rendering? Let's try again with HTML escapes:

    Ah, right, when copying from XChat it copied the username in angle brackets so it was <@ctsai-sf> which was copied in and made a mailto: link, that is the cause it was no mailto: link in the description of this issue. Actually I see now that my username is missing completely which was <Vampire> and which gets transformed to just nothing. So if between < and > no valid email address is written, it should be shown as plain text including the angle brackets.

     
  • Anonymous - 2013-01-03

    Originally by: vampire0

    Maybe it is also an idea to always show the preview before being able to post a comment or issue or having a checkbox that you have to enable to activate markdown syntax before positing. The default checked/unchecked state of this checkbox should then be configurable per user. But currently you have a textbox and if you just write or paste something in, you might not become what you expect, maybe because you are simply not aware that there is some transformation done. If a Preview, or a checkbox to do markdown transformations is required, then it is less likely to have accidental markdown syntax tokens in your text.

     

    Last edit: Anonymous 2015-10-20
  • Dave Brondsema

    Dave Brondsema - 2013-01-09
    • labels: --> 42cc
     
  • Igor Bondarenko - 2013-01-11

    Created #253: [#5538] Show invalid artifact links as plain text after markdownification (1cp)

     

    Related

    Tickets: #5538

  • Igor Bondarenko - 2013-01-11
    • status: open --> in-progress
     
  • Igor Bondarenko - 2013-01-23
    • status: in-progress --> code-review
     
  • Igor Bondarenko - 2013-01-23

    Closed #253. allura:42cc_5538

     
  • Cory Johns - 2013-01-28
    • status: code-review --> closed
    • qa: Cory Johns
    • milestone: forge-backlog --> forge-feb-08
     

Log in to post a comment.