IIRC, the JS for this does some weird stuff for submitting the form and setting a message. I think that needs to be fixed (do a regular form submit, next page load should have message) in addition to any other specific bugs.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
(2) Don't exactly sure what should be done, seems like it looks pretty well without this now.
(3) There are update_tickets in the RootController and in the MilestoneController. The first one used in mass edit. Seems like the second one used nowhere (at least we can't find such a place). Maybe you can point us where it's supposed to be used? If not, I guess, we might just delete it.
IIRC, the JS for this does some weird stuff for submitting the form and setting a message. I think that needs to be fixed (do a regular form submit, next page load should have message) in addition to any other specific bugs.
Created #299: [#5673] Improve bulk edit (2cp)
Related
Tickets:
#5673[#5494] provides some more specifics and probably can be closed out when this ticket is done.
Related
Tickets:
#5494Closed #299. Branch
je/42cc_5673
Regarding specifics in the [#5494]:
(1) and (4) are done.
(2) Don't exactly sure what should be done, seems like it looks pretty well without this now.
(3) There are
update_tickets
in theRootController
and in theMilestoneController
. The first one used in mass edit. Seems like the second one used nowhere (at least we can't find such a place). Maybe you can point us where it's supposed to be used? If not, I guess, we might just delete it.Related
Tickets:
#5494I went ahead and removed the two views on the Milestone controller because I agree that they are unused.