It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
A global nav with custom links would be nice too. E.g. logo would link back to project root, but you may want to add links to certain neighborhoods, projects, or external pages.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This is great -- I'm excited about this feature :)
This is looking great overall -- I just have a couple of notes:
1: We should add in some warnings instead of failing silently. Maybe something like:
ifnotos.path.isfile(image_full_path):log.warning('Could not find logo at: %s'%image_full_path)returnFalseifnotimage_path:log.warning('Image path not set for nav_logo')returnFalse
2: What do you think about making the image height settable or maybe just mentioning the ideal image dimensions in the comments?
3: For simple data structures like the one for “logo”, using a simple dot notation can be more readable:
logo.link = /
logo.path = logo.png
4: Because this is a universally useful feature -- it may be nice to mention it in our docs.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
A global nav with custom links would be nice too. E.g. logo would link back to project root, but you may want to add links to certain neighborhoods, projects, or external pages.
Closed #866.
ib/5940This is great -- I'm excited about this feature :)
This is looking great overall -- I just have a couple of notes:
1: We should add in some warnings instead of failing silently. Maybe something like:
2: What do you think about making the image height settable or maybe just mentioning the ideal image dimensions in the comments?
3: For simple data structures like the one for “logo”, using a simple dot notation can be more readable:
4: Because this is a universally useful feature -- it may be nice to mention it in our docs.
Setting height makes sense for me and logo notation would be great in this case for sure! Will do
Closed #880.
ib/5940a (rebased on master)
Note one test is failing here, but it is also failing on master. I've made fix for that https://forge-allura.apache.org/p/allura/git/merge-requests/63/
This looks great, Igor -- nice work!
merged
I've noticed a few followup issues with this, would you mind fixing?
Nice catch!
I'll change the status back to in-progress.
Fixed and created a merge request https://forge-allura.apache.org/p/allura/git/merge-requests/67/