Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, ccruz, deshani, and 11 others

#6093 better error middleware

Milestone: v1.0.0

Status: closed

Owner: Dave Brondsema

Labels: sf-1 (616)

Component: General

Reviewer: Cory Johns

Updated: 2015-08-20

Created: 2013-04-11

Creator: Dave Brondsema

Private: No

TurboGears standard error handler WebError doesn't work well with mod_wsgi processes. sfpy has custom error catching middleware and error template to display a trace in the web browser. We should use that in Allura also. And potentially enable the WebError or wdb in Allura when it's run with paster, since that's an even better debugger.

Discussion

Dave Brondsema - 2013-04-19

Size: --> 1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-04-19

status: open --> in-progress

assigned_to: Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-04-19

Remove processes from WSGIDaemonProcess directive (can't even be set to 1).

werkzeug

Comment out our tg.error.ErrorHandler middleware and put app = DebuggedApplication(app, evalex=True, console_path='/nf/__console__') after StatusCodeRedirect. Works well, but less is logged to stderr logs (no env vars) and c.app/project/user don't work in interactive debugging.

Still works with multiprocess, including limited interactive debugging (but doesn't work completely)

weberror

set debug=true in ini file

Requires hacks to modify /_debug URL to be /nf/_debug which is needed for our sandbox environment. c.app/project/user does still work. SSLMiddleware interferes with ErrorHandler. Putting ErrorHandler after it works, but then we'd miss some errors.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-04-22

status: in-progress --> code-review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-04-22

timermiddleware:db/6093 - needs release

allura:db/6093 - needs timermiddleware version bumped

SourceForge sandbox environment:

https://trac.sdot.me/trac/siteops/ticket/53507

https://trac.sdot.me/trac/siteops/ticket/53513
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-04-22

I've forked WebError at https://github.com/brondsem/weberror to support /nf/_debug instead of /_debug but decided not to use that, since it's only needed for the SF sandbox environment and we can modify our routing.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-04-23

sfpy:db/6093 - test with debug=false and ensure that /projects/ccaproj05/files/ shows a PFS error as flash message (that's the safe_message_from_exception functionality that we still keep around)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-04-23

QA: Cory Johns
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-04-24

status: code-review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.