Apache Allura™ / Tickets / #6714 Rename & move User.project

#6714 Rename & move User.project_role()

Milestone: v1.1.0

Status: closed

Owner: Cory Johns

Labels: cleanup (28) sf-1 (616)

Component: General

Reviewer: Tim Van Steenburgh

Updated: 2015-08-20

Created: 2013-09-27

Creator: Dave Brondsema

Private: No

The User.project_role method creates roles, which may not be what you want (and may cause a large number of roles to be added to mongo). Rename it to something that makes its "upsert" functionality clear.

Also move it to the ProjectRole class, as that is more closely related to its functionality.

Discussion

Dave Brondsema - 2013-10-04

Milestone: forge-oct-18 --> forge-nov-01
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-10-21

Size: --> 1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-10-23

status: open --> in-progress

assigned_to: Cory Johns
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-10-23

status: in-progress --> code-review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-10-23

allura:cj/6714

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-10-24

status: code-review --> in-progress
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-10-24

status: in-progress --> code-review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-10-24

allura:cj/6714
forge-classic:cj/6714

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-10-25

Note: ProjectRole.by_user was already in use in one place: Allura/allura/lib/security.py:all_allowed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-10-28

Yeah, I guess I should have mentioned that, but that was a new addition specifically to avoid the upsert behavior of User.project_role() so I figured it was practically part of this ticket. :-)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2013-10-31

QA: Tim Van Steenburgh
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2013-10-31

status: code-review --> in-progress
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2013-10-31

Couple test failures: https://sourceforge.net/p/allura/pastebin/5272858d0594ca58130c809e

(after rebasing to master)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-10-31

status: in-progress --> code-review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-10-31

Rebase and test fixes force-pushed to:
allura:cj/6714

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2013-11-01

This is gtg but would like to hold for a separate push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2013-11-04

status: code-review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Apache Allura™

Forge software for hosting software projects

Milestone

Searches

Help

#6714 Rename & move User.project_role()

Discussion