The ProfileSection system supports disabling and ordering via config (disable_entry_points.allura.user_profile.sections and user_profile_sections.order, respectively). The existing data on the profile should eventually be refactored to use the same system so that the entire profile can be configured as desired.
Edit: Improved caching and added docstring (force-push on allura:cj/7002)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Looks good, but there's a test failure on nosetests allura.tests.functional.test_user_profile:TestUserProfile.
Also, do you think we should add the activitystream.enabled config check to check_display()? I guess personally I don't care whether it's visible before AS is turned on site-wide, but not sure if anyone else does.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
allura:cj/7002
sftheme:cj/7002
The
ProfileSection
system supports disabling and ordering via config (disable_entry_points.allura.user_profile.sections
anduser_profile_sections.order
, respectively). The existing data on the profile should eventually be refactored to use the same system so that the entire profile can be configured as desired.Edit: Improved caching and added docstring (force-push on
allura:cj/7002
)Looks good, but there's a test failure on
nosetests allura.tests.functional.test_user_profile:TestUserProfile
.Also, do you think we should add the
activitystream.enabled
config check tocheck_display()
? I guess personally I don't care whether it's visible before AS is turned on site-wide, but not sure if anyone else does.I was assuming we'd disable the entry-point, but making it conditional so we can test it in prod would definitely be better. I'll do that.
Changes pushed to:
allura:cj/7002