#7069 unable to view/process merge requests when fork is deleted [ss6548]

v1.2.0
closed
nobody
42cc (432)
General
Tim Van Steenburgh
2015-08-20
2014-01-20
Chris Tsai
No

[forge:site-support:#6548]

https://sourceforge.net/p/mikmod/mercurial/merge-requests/
There are several merge requests from a deleted fork at the
above link: When I am logged in, I can't view/process them.
I'd like all those merge-requests to be deleted altogether,
because all of them were merged manually long ago.

Thanks.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2014-01-22

    Error trace from server logs is:

    File '/var/local/allura/Allura/allura/templates/repo/merge_request.html', line 19 in top-level template code
  {% extends 'allura:templates/repo/repo_master.html' %}
File '/var/local/allura/Allura/allura/templates/repo/repo_master.html', line 138 in top-level template code
  <span class="scm-tag-label">{{t}}</span>
File '/var/local/allura/Allura/allura/templates/jinja_master/master.html', line 126 in top-level template code
  {% block content %}{% endblock %}
File '/var/local/allura/Allura/allura/templates/repo/merge_request.html', line 52 in block "content"
  >{{ c.app.repo.merge_command(req) | safe }}</textarea></div>
File '/var/local/env-allura/lib/python2.7/site-packages/ForgeHg-0.1.21-py2.7.egg/forgehg/model/hg.py', line 54 in merge_command
  merge_request.downstream_repo_url,
File '/var/local/env-allura/lib/python2.7/site-packages/Ming-0.4.2-py2.7.egg/ming/utils.py', line 18 in __get__
  result = obj.__dict__[self.__name__] = self._func(obj)
File '/var/local/allura/Allura/allura/model/repository.py', line 712 in downstream_repo_url
  return c.app.repo.clone_url(
AttributeError: 'NoneType' object has no attribute 'repo'
     

  • Dave Brondsema

    Dave Brondsema - 2014-01-23
    • labels: --> 42cc
     

  • Dave Brondsema

    Dave Brondsema - 2014-01-23

    I think we should try to display as much of the page as possible even when the fork repo is gone, but say the fork was deleted when the template links to the fork or has merge instructions. Or something reasonable like that, so the merge request can still be updated.

     

  • Igor Bondarenko - 2014-01-24
    • status: open --> in-progress
     

  • Igor Bondarenko - 2014-01-31
    • status: in-progress --> code-review
     

  • Igor Bondarenko - 2014-01-31

    Closed #525. je/42cc_7069

     

  • Tim Van Steenburgh - 2014-01-31
    • QA: Tim Van Steenburgh
    • Milestone: limbo --> forge-feb-7
     

  • Tim Van Steenburgh - 2014-02-03
    • status: code-review --> in-progress
     

  • Tim Van Steenburgh - 2014-02-03

    This looks good, but it would be good to get at least one functional test to assert that the merge request detail page loads properly when the downstream repo has been deleted.

     

  • Dave Brondsema

    Dave Brondsema - 2014-02-07
    • Milestone: forge-feb-7 --> forge-feb-21
     

  • Igor Bondarenko - 2014-02-10
    • status: in-progress --> code-review
     

  • Igor Bondarenko - 2014-02-10

    Closed #527.

    Rebased and force-pushed je/42cc_7069

     

  • Tim Van Steenburgh - 2014-02-11
    • status: code-review --> closed
     

  • Dave Brondsema

    Dave Brondsema - 2015-01-05
    • Milestone: unreleased --> asf_release_1.2.0
     

Log in to post a comment.