By using the App from g.entry_points instead of hard-coding the App class name in the importer, we can make the default importers use custom, subclassed Apps w/o needing to subclass the importer also.
One minor test fix (added setup_unit_test to ForgeImporters/forgeimporters/github/tests/test_code.py:TestGitHubRepoImporter.test_import_tool_happy_path), and now waiting on pythontree update to merge.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
summary: Refactor tool importers to use target_app for g.entry_points --> Refactor tool importers to use target_app for g.entry_points -- NEEDS CONFIGTREE
status: code-review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
summary: Refactor tool importers to use target_app for g.entry_points -- NEEDS CONFIGTREE --> Refactor tool importers to use target_app for g.entry_points -- NEEDS INI
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
allura:tv/7111
forge-classic:tv/7111
configtree:tv/7111
tracwikiimporter:tv/7111
mediawikimporter:tv/7111
googlecodewikiimporter:tv/7111
One minor test fix (added
setup_unit_test
toForgeImporters/forgeimporters/github/tests/test_code.py:TestGitHubRepoImporter.test_import_tool_happy_path
), and now waiting on pythontree update to merge.