#7800 Standardize IP addr lookup

v1.2.0
closed
Dave Brondsema
sf-1 (616)
General
Igor Bondarenko
2015-08-20
2014-11-20
Dave Brondsema
No

We do req.headers.get('X_FORWARDED_FOR', req.remote_addr) in many places and request.headers.get('X-Remote-Addr', request.remote_addr) in one. We should standardize this and make the custom header a .ini setting so that folks can use whatever they need (or none) based on their deployment configuration.

I think we should default to none since that is safest. In development.ini we can show an example config for X_FORWARDED_FOR since that is common.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2014-11-20
    • labels: --> sf-current, sf-1
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2014-11-21
    • status: in-progress --> review
     

  • Dave Brondsema

    Dave Brondsema - 2014-11-21

    Implemented in branch db/7800

    (SourceForge internally has a configtree branch too)

     

  • Igor Bondarenko - 2014-11-25
    • Reviewer: Igor Bondarenko
     

  • Igor Bondarenko - 2014-11-25
    • status: review --> closed
     

  • Dave Brondsema

    Dave Brondsema - 2014-12-01
    • labels: sf-current, sf-1 --> sf-1
     

  • Dave Brondsema

    Dave Brondsema - 2015-01-05
    • Milestone: unreleased --> asf_release_1.2.0
     

Log in to post a comment.