#7820 Validate URLs when configuring external link tool

v1.3.0
closed
General
2015-08-20
2015-01-26
No

We should validate URLs when setting up an external link. And add a missing http(s):// automatically would be helpful.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-03-09
    • labels: ux, bitesize --> ux, bitesize, sf-1, sf-current
     
  • Igor Bondarenko - 2015-03-10
    • Owner: Anonymous --> Igor Bondarenko
    • Labels: ux, bitesize, sf-1, sf-current --> sf-1, bitesize, 42cc, sf-current, ux
    • Status: open --> in-progress
     
  • Igor Bondarenko - 2015-03-19
    • status: in-progress --> review
     
  • Igor Bondarenko - 2015-03-19

    Closed #747. ib/7820

    I've overridden some of DefaultAdminController's methods and options configuration template to implement this, but I think we need more general approach for adding validators to tool's options in the future. Perhaps we can allow to specify validator(s) when defining ConfigOptions and implement actual validation in DefaultAdminController.configure + add ajax form submit/error handling in general template too, so then custom app can just specify validator and don't add any boilerplate. I didn't implement this now, because I think it is beyond the scope of this ticket, but maybe we should have this.

     
  • Dave Brondsema

    Dave Brondsema - 2015-03-23
    • status: review --> closed
    • Reviewer: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2015-03-23

    I agree a more "formal" way to enforce validations would be good, but this is sufficient for now.

     
  • Dave Brondsema

    Dave Brondsema - 2015-04-06
    • labels: sf-1, bitesize, 42cc, sf-current, ux --> sf-1, bitesize, 42cc, ux
     
  • Igor Bondarenko - 2015-06-18
    • Milestone: unreleased --> asf_release_1.3.0
     

Log in to post a comment.