#7827 Upgrade jQuery to latest version

v1.3.0
closed
Igor Bondarenko
42cc (432) sf-2 (994)
General
Dave Brondsema
2015-08-20
2015-02-06
Igor Bondarenko
No

See [#6297] for some thoughts and context

Related

Tickets: #6297

Discussion

  • Igor Bondarenko - 2015-02-06
    • labels: --> 42cc
    • status: open --> in-progress
    • assigned_to: Igor Bondarenko
     

  • Dave Brondsema

    Dave Brondsema - 2015-02-09
    • labels: 42cc --> 42cc, sf-current
     

  • Dave Brondsema

    Dave Brondsema - 2015-02-09
    • labels: 42cc, sf-current --> 42cc, sf-current, sf-2
     

  • Igor Bondarenko - 2015-02-10

    Closed #722. ib/7827

    Earlier version of allura-base.js have contained "tooltip" plugin. I see that it is used in two places in code (see below), but can't find it anywhere on UI, so I didn't include it for now. Maybe you know what it was used for and can point out it to me, so I can add it back and check that it still works?

    Allura/allura/public/nf/js/allura-base.js
25:        $this.tooltip({showURL: false});

Allura/allura/lib/widgets/project_list.py
98:                $(badges[i]).parent('a[title]').tooltip({

    QA:

    Browse the site and watch for errors related to jQuery in the developer console.

    You can also revert [02a539e] to be able to see jquery-migrate warnings, if any (ignore the $.browser one, since we have a piece of code for that).

    Some areas to check:

    • forms (especially ticket create/edit, since it has a lot of custom widgets)
    • comments, replies
    • admin UI (permissions, tools, etc)
    • tracker field management
    • ticket filters, milestones, etc
    • whatever you may think of

    Also, make sure it fixes [#6297] and close it too.

     

    Related

    Tickets: #6297

    • Dave Brondsema

      Dave Brondsema - 2015-02-11

      I think the tooltip stuff can go.

      The first reference you gave doesn't match on anything in our current templates I don't think. I traced it back to commit [d36ab9], before we were even using jinja. I don't think that HTML structure was kept.

      The second reference can come through via the [[projects]] macro, but I believe the js is not used. <small class="badge"> was removed in [ed2751]

      BTW, I'm making some small adjustments in sftheme to support the jquery upgrade.

       

  • Igor Bondarenko - 2015-02-10
    • status: in-progress --> review
     

  • Dave Brondsema

    Dave Brondsema - 2015-02-19

    jquery is missing altogether from /auth/ pages and /p/import_project pages. (TODO: test login overly on /p/import_project/google-code/ when jquery is there). Can cleanup the tooltip and badge stuff I mentioned above, as you see fit.

    Created an internal SourceForge ticket for some changes needed there (#10191)

     

  • Dave Brondsema

    Dave Brondsema - 2015-02-19
    • status: review --> in-progress
    • Reviewer: Dave Brondsema
     

  • Igor Bondarenko - 2015-02-24

    Closed #734. Force-pushed ib/7827 (rebase)

    Take a look at login overlay at /p/import_project/github/. It doesn't show up right on my sandbox (see attachment), even on master and release versions. However it looks fine on forge-allura.apache.org which uses 1.2.1 release, so I assume it is something with my sandbox. I've tried allurasitetheme also, with the same result. sftheme looks fine, though.

     
    Thumbnail
    overlay.png

    • Dave Brondsema

      Dave Brondsema - 2015-02-24

      That overlay size is wrong because of a login_fragment.html template override for SourceForge only. If you set disable_template_overrides = True in your .ini file then it works fine (or uninstall ForgeSF and stop using any providers from it). So I think everything's ok in that regard.

       

  • Igor Bondarenko - 2015-02-24
    • status: in-progress --> review
     

  • Dave Brondsema

    Dave Brondsema - 2015-02-24
    • status: review --> closed
     

  • Dave Brondsema

    Dave Brondsema - 2015-03-09
    • labels: 42cc, sf-current, sf-2 --> 42cc, sf-2
     

  • Igor Bondarenko - 2015-06-18
    • Milestone: unreleased --> asf_release_1.3.0
     

Log in to post a comment.