Our plaintext mail messages just send markdown without converting it to HTML. So all plain text views will see some markdown formatting. Commit notifications also include HTML tags in each commit message. This is from the summary = g.markdown_commit.convert(ci.message)
in def send_notifications
rendering commit-markdown -> HTML. (Before [#7825] the commit message text was just passed through without this step but that caused inadvertent markdown formatting for things like __init__
, or if (*pArray[j+1] > *pArray[j])
Example of the HTML coming through in plain text: https://forge-allura.apache.org/p/allura/pastebin/557b1ce16d19cd7007456025
I think a fix for this would have to include a way for commit notification logic to build the plain text version separately and pass that in to the mail functions.
The markdown conversion of each commit msg to HTML creates
<div ..... </div>
sections which is good for the later conversion to HTML mail, because markdown->HTML will skip past the<div>
html sections. But it's not appropriate for the plaintextOptions:
```
or individual characters with backslashes.<div>
tags already act like that for us, best option.Last edit: Dave Brondsema 2017-07-06
Fixed fairly well on db/8157
Merged.