#7906 Fix login check on ApacheAccessHandler.py

v1.3.1
closed
Dave Brondsema
sf-1 (616)
General
Heith Seewald
2015-07-13
2015-06-29
Dave Brondsema
No

After the login CSRF changes done in [#7893] the login check done in ApacheAccessHandler.py doesn't work. (ApacheAccessHandler.py is used for auth checks when accessing a repo)

Related

Tickets: #7893

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-06-29
    • status: in-progress --> review
     

  • Dave Brondsema

    Dave Brondsema - 2015-06-29

    db/7906

    QA:

    Believe me when I say this fixed it for forge-allura.apache.org's repo hosting. Otherwise set it your own according to https://forge-allura.apache.org/docs/getting_started/scm_host.html

    It would be nice to have tests for this, but it would have to be an integration test with running services, to catch something like this.

     

  • Heith Seewald - 2015-06-29
    • Reviewer: Heith Seewald
     

  • Heith Seewald - 2015-06-29

    Looks good. Merged.

     

  • Heith Seewald - 2015-06-29
    • status: review --> closed
     

  • Dave Brondsema

    Dave Brondsema - 2015-07-13
    • labels: sf-current, sf-1 --> sf-1
     

  • Dave Brondsema

    Dave Brondsema - 2015-08-10
    • Milestone: unreleased --> v1.3.1
     

Log in to post a comment.