#7984 Fix layout at bottom of subscriptions page

v1.3.2
closed
Dave Brondsema
ux (103) sf-2 (994)
General
nobody
2015-10-19
2015-09-04
Dave Brondsema
No

/auth/subscriptions has a bad layout under the table. It'd be better to have "Email Format" and the dropdown adjacent to each other on the same line. And then align the "Save" button to the far right, also on the same line.

A few other relatively easy cleanup tasks would be:

  • remove Topic, Type, and Frequency columns, since they aren't used
  • rename App to Tool
  • provide a way for apps to indicate they don't have any notifications (search, admin, activity, etc) and skip the rows for those types of apps

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-09-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1 @@
-`/auth/subscriptions` has a bad layout under the page.  It'd be better to have "Email Format" and the dropdown adjacent to each other on the same line.  And then align the "Save" button to the far right, also on the same line.
+`/auth/subscriptions` has a bad layout under the table.  It'd be better to have "Email Format" and the dropdown adjacent to each other on the same line.  And then align the "Save" button to the far right, also on the same line.
     

  • Dave Brondsema

    Dave Brondsema - 2015-09-30
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,7 @@
 `/auth/subscriptions` has a bad layout under the table.  It'd be better to have "Email Format" and the dropdown adjacent to each other on the same line.  And then align the "Save" button to the far right, also on the same line.
+
+A few other relatively easy cleanup tasks would be:
+
+* remove Topic, Type, and Frequency columns, since they aren't used
+* rename App to Tool
+* provide a way for apps to indicate they don't have any notifications (search, admin, activity, etc) and skip the rows for those types of apps
     

  • Dave Brondsema

    Dave Brondsema - 2015-10-05
    • labels: ux --> ux, sf-2, sf-current
     

  • Dave Brondsema

    Dave Brondsema - 2015-10-12
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2015-10-14
    • status: in-progress --> review
     

  • Dave Brondsema

    Dave Brondsema - 2015-10-14

    Done in db/7984

    (also SF repo force-classic has a few minor tweaks in db/7984)

     

  • Igor Bondarenko - 2015-10-15
    • status: review --> closed
     

  • Igor Bondarenko - 2015-10-15

    Looks good.

    I've merged open source part only, since some tests are failing in forge-classic (see https://sourceforge.net/p/allura/tickets/10612/)

     

  • Dave Brondsema

    Dave Brondsema - 2015-10-19
    • labels: ux, sf-2, sf-current --> ux, sf-2
     

  • Dave Brondsema

    Dave Brondsema - 2015-12-08
    • Milestone: unreleased --> v1.3.2
     

Log in to post a comment.