Apache Allura™ / Tickets / #8040 Upgrade SimpleMDE and contribute our toggleCodeBlock

#8040 Upgrade SimpleMDE and contribute our toggleCodeBlock

Milestone: v1.5.0

Status: closed

Owner: Dave Brondsema

Labels: sf-current (14) sf-4 (350)

Component: General

Reviewer: Heith Seewald

Updated: 2016-04-28

Created: 2016-01-06

Creator: Dave Brondsema

Private: No

Now that [#7987] has us on a standard rendering of code blocks, we should contribute our toggleCodeBlock functionality back to SimpleMDE. It needs a bit of cleanup with extra \n insertion no longer needed.

We'll need to upgrade to the latest version, which might require some changes. And once our contribution is accepted, upgrade to that release too.

Dave Brondsema - 2016-01-19

status: open --> in-progress

assigned_to: Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-01-20

https://github.com/NextStepWebs/simplemde-markdown-editor/pull/228

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-01-25

labels: --> sf-current, sf-4
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-01-26

status: in-progress --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-01-26

db/8040

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-03-11

Looks good with the exception of the "insert table" button.

Clicking it causes: Uncaught ReferenceError: _replaceSelection is not defined

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-03-11

status: review --> in-progress
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-04-27

status: in-progress --> review

Reviewer: Heith Seewald
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-04-27

Fixed insert table button.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-04-28

status: review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-04-28

Looks good. Merged/closed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-08-22

Milestone: unreleased --> v1.5.0
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Apache Allura™

Forge software for hosting software projects

Milestone

Searches

Help

#8040 Upgrade SimpleMDE and contribute our toggleCodeBlock

Related

Discussion