#8081 Subscriptions page should have the issues' Title column NEEDS MIGRATION

v1.10.0
closed
Shalitha Suranga
None
Admin
Dave Brondsema
2018-10-30
2016-04-15
Federico Bruni
No

The subscriptions page on the account preferences currently lists 4 columns: project, tool, item and the check option.
The item number doesn't tell much. In order to make it useful, I think that you should add also a column with the title of the issue. There's a lot of padding between each column now. If the title is too long, it should be wrapped at a fixed maximum length.

Discussion

  • Federico Bruni - 2016-04-18

    Another annoying issue is that all issues (open and closed) are listed. It would be good to be able to list only the open issues.

     

  • Shalitha Suranga - 2018-10-11

    Ticket is having link with the ticket number then user can go ahead at check what it is. But merge requests are displaying the title. Therefore can we add title for tickets too to make those two things (MR and Ticket) similar?

    your ideas?

     

    • Dave Brondsema

      Dave Brondsema - 2018-10-16

      Discussion threads also show their title. So it must be some property of the Artifact class that some types implement nicely but Ticket doesn't do the way we want. Or perhaps how the Mailbox class which stores all the subscriptions. It would be good to add/update to the ticket logic so it works like the others.

       

  • Shalitha Suranga - 2018-10-21

    Hi.. Dave

    I checked this further. Here is how merge request put versioned artifact title

            result = Artifact.index(self)
        result.update(
            name_s='Merge Request #%d' % self.request_number,
            type_s=self.type_s,
            title=self.email_subject,
        )

    And email subject returns u'Merge request: ' + self.summary So in each email we get [allura:git] Merge request: .... and each subscription we see Merge request: ......

    But in ticket it is different 

    result = VersionedArtifact.index(self)
        result.update(
            title='Ticket %s' % self.ticket_num,
            ............
            .....

    Versioned artifact doesn't use email_subject property.

    '#%s %s' % (self.ticket_num, self.summary)

    If we do same as MR(putting title=self.email_subject) we get something like [allura:tickets] Ticket #323 ... in email and Ticket #323 ... in subcriptions
    Okay. but word ticket is repeating

    So I would suggest this

    repo model

        def index(self):
        result = Artifact.index(self)
        result.update(
            name_s='Merge Request #%d' % self.request_number,
            type_s=self.type_s,
            title='Merge Request #%d: %s' % (self.request_number, self.summary),
            # modified here
        )
        return result

    ticket model

       def index(self):
        result = VersionedArtifact.index(self)
        result.update(
            title='Ticket #%d: %s' % (self.ticket_num, self.summary),
            version_i=self.version,
            type_s=self.type_s,
            created_date_dt=self.created_date,

    Then both will look same.(We can solve this ticket) and email subjects also remain same

     

  • Dave Brondsema

    Dave Brondsema - 2018-10-22

    If I'm following everything correctly that sounds good to me. The email subjects are good how they are so you're right that we don't want to change those. Want to make a merge request for it and I can double check everything?

    Thanks

     

  • Shalitha Suranga - 2018-10-23

    Yeah :) added a MR . There was no trouble with unit cases

     

  • Shalitha Suranga - 2018-10-23
    • status: open --> in-progress
     

  • Shalitha Suranga - 2018-10-23
    • status: in-progress --> review
     

  • Dave Brondsema

    Dave Brondsema - 2018-10-23

    I've merged the MR. That handles all new subscriptions to tickets.

    I'm going to keep this ticket open for the time being though, so we can think about updating the titles for existing ticket subscriptions. That might be nice to do. We'd probably need a script similar to the ones in scripts/migrations.

     

    • Shalitha Suranga - 2018-10-23

      Yeah.. okay.. persisted data needs to be changed. I will look existing scripts

       

  • Shalitha Suranga - 2018-10-25

    Hi.. Dave

    Can you check my script here. Probably we need to add to Upgrade Instructions in new version I guess. otherwise when user upgrades old data is still there

    Thanks

     

  • Dave Brondsema

    Dave Brondsema - 2018-10-26
    • summary: Subscriptions page should have the issues' Title column --> Subscriptions page should have the issues' Title column NEEDS MIGRATION
    • status: review --> closed
    • assigned_to: Shalitha Suranga
    • Reviewer: Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2018-10-26

    I'm updating the title of this ticket so the "NEEDS MIGRATION" wording will appear in our changelog when we make the next release, and remind us to add the migration command to the upgrade instructions. This is what will need to be run:

    paster script your-ini-file.ini ../scripts/migrations/034-update_subscriptions_ticket_and_mr_titles.py
     

  • Dave Brondsema

    Dave Brondsema - 2018-10-30
    • Milestone: unreleased --> v1.10.0
     

Log in to post a comment.