Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, ccruz, deshani, and 11 others

#8161 Switch from React to Preact - or upgrade to React 16

Milestone: v1.8.0

Status: closed

Owner: Dave Brondsema

Labels: licensing (6)

Component: General

Reviewer: nobody

Updated: 2018-02-05

Created: 2017-08-21

Creator: Dave Brondsema

Private: No

Facebooks BSD+Patents license, used for React, is not compatible with ASF policies. https://www.apache.org/legal/resolved#category-x

We need to switch, e.g. to https://preactjs.com/ We use React for the admin/edit mode in the project menu, phone verification dialog, and subscribing to individual pages.

Discussion

Dave Brondsema - 2017-09-25

summary: Switch from React to Preact --> Switch from React to Preact - or upgrade to React 16
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2017-09-25

Now they're going to license it as MIT. https://code.facebook.com/posts/300798627056246/relicensing-react-jest-flow-and-immutable-js/ So I guess we just have to upgrade to React 16 (once its out) to get the MIT licensed version.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2017-09-26

React 16 is out. https://facebook.github.io/react/blog/2017/09/26/react-v16.0.html It does mention 15.6.2 is licensed under MIT too. We're on v0.14.3, but could help I guess if 16 has some backwards compatibility issue.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2017-09-27

status: open --> review

assigned_to: Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2017-09-27

The react-drag and react-reorderable projects have had a few updates, but not much. Seems to work fine leaving them as-is.

Test:

run npm run build

subscribe icon in action bar

Add New & navbar admin mode (drag/drop, settings menu, grouped tools, threshold control, etc)

phone verification on new project registration

need to be a user with no projects (e.g. "test-user")

need project.verify_phone and phone.* settings in .ini

in .ini file, change debug = true to false and restart web server, which to confirm using using the minified react file instead of the full debug version works correctly too.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kenton Taylor - 2017-10-02

status: review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kenton Taylor - 2017-10-02

Merged.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2018-02-05

Milestone: unreleased --> v1.8.0
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.