Yea a lightbox could be a nice improvement. We have some existing lightbox patterns, like the allura.lib.widgets.form_fields.Lightbox class - however that uses "easy widgets" which often is not easy to work with at all. I think you can do it more direclty with just html/css/js. Commit [ecf45d] might be a good reference example. Having it all inside a markdown macro might make it trickier though.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Yep,
[[project_screenshots]]
exists as a wiki macro already.Hi Dave
Yes it looks good. Is it better to add light box instead of normal image link ?
Yea a lightbox could be a nice improvement. We have some existing lightbox patterns, like the
allura.lib.widgets.form_fields.Lightbox
class - however that uses "easy widgets" which often is not easy to work with at all. I think you can do it more direclty with just html/css/js. Commit [ecf45d] might be a good reference example. Having it all inside a markdown macro might make it trickier though.Hi.. Dave
Okay thanks I will give a merge request
Hi.. Dave
Added a MR https://forge-allura.apache.org/p/allura/git/merge-requests/291/
Thanks!