#8243 Template extension point to wrap all content

v1.10.0
closed
Kenton Taylor
None
General
Dave Brondsema
2018-10-30
2018-10-12
Kenton Taylor
No

A mechanism is needed within the master template to optionally allow wrapping of all page content, for the purposes of an off-canvas menu (for smaller screens). This is an initial stepping stone in the larger effort to move Allura in a responsive direction.

Discussion

  • Kenton Taylor - 2018-10-12
    • status: open --> in-progress
     

  • Kenton Taylor - 2018-10-12
    • status: in-progress --> review
     

  • Kenton Taylor - 2018-10-12

    kt/8243

     

  • Dave Brondsema

    Dave Brondsema - 2018-10-12
    • status: review --> in-progress
    • Reviewer: Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2018-10-12

    Getting lots of errors. I think you need to reference it like theme_macros.all_content_wrapper

     

  • Kenton Taylor - 2018-10-12

    Indeed, fixup pushed.

     

  • Kenton Taylor - 2018-10-12
    • status: in-progress --> review
     

  • Dave Brondsema

    Dave Brondsema - 2018-10-12

    Still getting a few test failures. They appear to be with flash messages; looks like the scope of {% set flash ... may be the problem.

     

    • Kenton Taylor - 2018-10-15

      Good catch, fixup pushed.

       

  • Dave Brondsema

    Dave Brondsema - 2018-10-15
    • status: review --> closed
     

  • Dave Brondsema

    Dave Brondsema - 2018-10-30
    • Milestone: unreleased --> v1.10.0
     

Log in to post a comment.