Embedded youtube videos are trackers, as they are storing coockies for a foreign host. With the new european GDPR that's a problem. Currently I patched macros.py and utils.py to patch the URL:
embed_url = html.find('iframe').get('src').replace("youtube.com", "youtube-nocookie.com")
But I don't know what the correct solution for this problem might be. At least we need to allow the nocookie URLs if the user adds those. But I guess that's not enough, as I don't think that you can't easily pass the responsibility for trackers on project pages to the admin of the page.
I like the idea of using youtube-nocookie.com. I think making the changes in macro.py and utils.py (and tests probably) is the right way to go. Iframes are only possible using the
[[embed
macro, project admins can't add a youtube.com iframe themselves. So I think the types of you changes you describe will handle the embed macro and that'll be good.On branch db/8261 allows embed code to use youtube-cookie.com urls and converts iframe output to youtube-nocookie (for both youtube or youtube-nocookie inputs)
Looks good, merged.