Apache Allura™

Hi..

I've added new checkbox to turn on/off user mention notifications via ss/8285. when we merge this we can update our other branch with new preference item.

Thanks

• allow_umnotif and True or False is kinda confusing to me to read. How about bool(allow_umnotif) instead?
• small grammar improvement: Send a notification via e-mail if my username is mentioned in somewhere remove "in" so it is just ... mentioned somewhere
• we should add an audit log entry when the preference is changed (use h.auditlog_user)

Suggestions for next steps / further work:

• like you said - merge this branch with ss/8284 and check the preference
• a script to update all existing users to set the notification preference (see Allura/allura/scripts/backfill_previous_login_details.py as an example of the general idea (although it accidentally has pagesize=2 that shouldn't be there).
• default new users to have the notification preference on
• in the notification emails, have an unsubscribe link that goes to the subscriptions page and the preference form

Hi.. Updated ss/8285 with suggested improvements. Meanwhile you review I will continue with next steps in other branch (ss/8284) and other followup tasks

Hi.. @brondsem is there any modifications further? Can I continue and merge with 8284?

Thanks

ss/8285 looks fine

Hi.. @brondsem next steps 1,2 and 3 done and upated ss/8285.

Regarding 4
We can easily add id to notification title
<h2 id="notifcations">User notifications</h2>
and change email's link to <link>#notifications it works properly when user is already logged. but when user is not logged # part is gone because # is not supported in query params. I tried %23 instead but didn't work.

Do you have idea to solve this?

Thanks

Hi...
Item 4 also added to ss/8285

Thanks

Looks good, I've merged this and will close [#8284] also. What are you working on next then? This is the last of the tickets you initially made, but I'm thinking there should be some test coverage for this latest functionality added. Your project proposal also mentions documentation and formatting guide updates. Also I think [#8293] would be pretty nice.

Hi.. @brondsem

I was recently checking [#8294] but it looks tricky because sounds it needs custom code mirror mode to add custom tokens and in our case we need to add custom token to existing mode. (gfm). If there is hard approach to do it we may check that in future

Yeah formatting guide, feature blog post needs to be updated/created

Could u advice for which part tests are required. As I can remember for some required parts I have added tests.

Meanwhile I will check [#8293]

Thanks