#8540 fix wiki page 'recent' sort

v1.17.0
closed
None
General
nobody
2024-06-10
2024-03-28
No

The "Recently Updated" sort option on wiki's Browse Pages does not work correctly. It does the query and then applies a sort afterwards. So if you have more than one page of results, it only sorts within the current page not the whole set of pages.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2024-03-28
    • status: open --> review
    • assigned_to: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2024-03-28

    fixed on db/8540

    there aren't any tests, and I didn't add any. But you can test manualyl: create just 4 or 5 wiki pages and then go Browse Pages, then click on the sort options. Then add &limit=2 to the URL to force small page sizes to see the problem & verify the fix.

     
  • Guillermo Cruz - 2024-03-29
    • status: review --> closed
     
  • Guillermo Cruz - 2024-03-29

    Looks good I'll merge

     
  • Dave Brondsema

    Dave Brondsema - 2024-06-10
    • Milestone: unreleased --> v1.17.0
     

Log in to post a comment.