#8555 check blocked users better

v1.17.0
closed
None
General
nobody
2024-06-10
2024-04-02
No

If a user is blocked at the tool level, they still may be able to post in discussion forums that have additional ACLs. E.g. a forum within the discussion tool, which has anonymous posting allowed, or has developer only posting.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2024-04-02

    db/8555

    It was tempting to change this has_access code:

    # access is denied for this role
    break
    

    to be return False. That would've fixed this situation, but made several other tests fail. Instead, I decided it'd be better to change a few non-core places, and not change the core has_access logic (even if maybe it deserves a refactor some day)

     
  • Dave Brondsema

    Dave Brondsema - 2024-04-03
    • status: in-progress --> review
     
  • Guillermo Cruz - 2024-04-04
    • status: review --> closed
     
  • Guillermo Cruz - 2024-04-04

    merged

     
  • Dave Brondsema

    Dave Brondsema - 2024-06-10
    • Milestone: unreleased --> v1.17.0
     

Log in to post a comment.