Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, ccruz, deshani, and 11 others

Git Merge Request #138: Improve design of merge requests filter and add confirmation to accept reject merge requests (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Original repository by Rohan Verma is deleted

Improve design of merge requests listing filter

Before:
Before
After:
After

Discussion

Rohan Verma - 2016-07-12

Summary: Improve --> Improve design of merge requests listing filter
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rohan Verma - 2016-07-12

Description:

Diff:

--- old +++ new @@ -1 +1,6 @@ Improve design of merge requests listing filter + +**Before:** +![Before](http://i.imgur.com/ZHFxZWn.png) +**After:** +![After](http://i.imgur.com/wHXUOWF.png)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-07-15

Since mr_filter is no longer used, it should be deleted, including the SCMMergeRequestFilterWidget class, etc. (I don't think we need it in the @validate line any more either)

How about an option to view all?

It'd be nice if the currently selected one was displayed differently. You can do this if you use btn-set on a div or span around them all and then each one has class btn instead of btn-set. Then add active class to the current one. vote.html has an example of this.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rohan Verma - 2016-07-18

Status: open --> rejected
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rohan Verma - 2016-07-18

Status: rejected --> open
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rohan Verma - 2016-07-18

Summary: Improve design of merge requests listing filter --> Improve design of merge requests filter and add confirmation to accept reject merge requests
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rohan Verma - 2016-07-18

Also added a confirmation before accepting/rejecting merge requests.

Last edit: Rohan Verma 2016-07-18

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-07-19

The CSS changes renames .nested-grid-container to .filter-container but the wiki browse page still uses nested-grid-container and needs those rules.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Rohan Verma - 2016-07-26
  
  I don't know why but this branch got ruined so created patches and made a new MR https://forge-allura.apache.org/p/allura/git/merge-requests/148/
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rohan Verma - 2016-07-26

Status: open --> rejected
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.