Since mr_filter is no longer used, it should be deleted, including the SCMMergeRequestFilterWidget class, etc. (I don't think we need it in the @validate line any more either)
How about an option to view all?
It'd be nice if the currently selected one was displayed differently. You can do this if you use btn-set on a div or span around them all and then each one has class btn instead of btn-set. Then add active class to the current one. vote.html has an example of this.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Diff:
Since
mr_filter
is no longer used, it should be deleted, including theSCMMergeRequestFilterWidget
class, etc. (I don't think we need it in the@validate
line any more either)How about an option to view all?
It'd be nice if the currently selected one was displayed differently. You can do this if you use
btn-set
on adiv
orspan
around them all and then each one has classbtn
instead ofbtn-set
. Then addactive
class to the current one.vote.html
has an example of this.Also added a confirmation before accepting/rejecting merge requests.
Last edit: Rohan Verma 2016-07-18
The CSS changes renames
.nested-grid-container
to.filter-container
but the wiki browse page still usesnested-grid-container
and needs those rules.I don't know why but this branch got ruined so created patches and made a new MR https://forge-allura.apache.org/p/allura/git/merge-requests/148/