Git Merge Request #154: View Action Button using meta information and extra metalink in sendmail function (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Rohan Verma wants to merge 1 commit from /u/rhnvrm/allura/ to master, 2016-08-16

View Action Button:
I have verified it on outmail and the meta tags are being embedded correctly but I am not sure if it will appear correctly in email. Also have checked it using https://www.google.com/webmasters/markup-tester/u/0/ but before using it in production, we need to register with google here: https://developers.google.com/gmail/markup/registering-with-google
This will need to be tested and then registered on the Allura and Sourceforge production servers.

Commit Date  
[1d5a5b] (rhnvrm/action-button-gmail) by Rohan Verma Rohan Verma

Added optional parameter metalink in sendmail function that adds a view button in email clients

2016-05-25 23:38:13 Tree

Discussion

  • Dave Brondsema

    Dave Brondsema - 2016-08-16

    Sorry I forgot about this merge request for a little bit. There are a couple test failures in Allura/allura/tests/model/test_notification.py but there was a commit in the original merge request https://forge-allura.apache.org/p/allura/git/merge-requests/129/ which fixed it. I've merged this commit and the test-fix commit.

     
  • Dave Brondsema

    Dave Brondsema - 2016-08-16
    • Status: open --> merged
     

Log in to post a comment.