Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, deshani, dill0wn, and 10 others

Git Merge Request #265: [#8215] Personal Dashboard - Create Merge Requests Section (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Deshani wants to merge 3 commits from /u/deshani/allura-personal-dashboard/ to master, 2018-07-06

Commit	Date
[047fa2] (merge_requests_section) by deshanigtk [#8215] Personal Dashboard - Sort based on 'mod_date' descending order	2018-07-06 16:26:15	Tree
[76787d] by deshanigtk [#8215] Personal Dashboard - Fix the link of merge request, add 'creator_id' to index list and sort search results according to 'mod_date'	2018-07-06 05:17:32	Tree
[5bf4e7] by deshanigtk [#8215] Personal Dashboard - Create Merge Requests Section	2018-07-04 18:43:38	Tree

Discussion

Deshani - 2018-07-04

Source branch: master --> merge_requests_section
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2018-07-05

Hi,

Looks like a good start. A few things to change are:

the links don't go to the right place. Instead of linking to {{ req.request_number }}/ it needs to be {{ req.url() }} to get a full url that works from the dashboard page

should have a blank line before def my_merge_requests

if querying by creator_id there should be a mongo index for that field so that its not slow on large databases. You can add it to the MergeRequest.__mongometa__.indexes list.

a different option would be to search solr instead of querying mongo. I think this could be done a lot simpler than the ticket solr search works. But doing the mongo query and just adding the index for it is fine.

IMO, sorting by mod_date is probably more useful than by request_number (If you have merge requests on multiple repos, the numbers will be varied)

-Dave
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Deshani - 2018-07-06
  
  Hi Dave,
  
  Thanks for reviewing. I've updated the merge request with the required changes.
  
  Regards!
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2018-07-06

Hi,

The sorting is showing the oldest merge requests first, not the newest.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Deshani - 2018-07-06
  
  Hi,
  
  I've updated the merge request
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2018-07-06

Status: open --> merged
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.