Git Merge Request #381: Enhancements for backlinks from ticket to Git commit and unsubscribe feature (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Vrinda A wants to merge 9 commits from /u/vrinda/allura/ to master, 2022-03-07

Commit Date  
[14263d] (HEAD, master) by Vrinda A Vrinda A

[#5593] Create backlink from ticket when commit message contains ticket link

 2021-12-01 13:53:58 Tree
[7630ac] by Vrinda A Vrinda A

[#8391] Unsubscribe from a project when a user is removed from Admin group

 2021-12-01 13:52:54 Tree
[e89bf0] by Vrinda A Vrinda A

Updated requirements.txt with profanityfilter

 2019-10-15 09:37:00 Tree
[f2c0ff] by root root

Revert "Feedback app"

This reverts commit 8d1d8734c31eac2c8257d75a592dbb5a99e3ceef.

 2019-10-10 11:29:37 Tree
[8d1d87] by Vrinda A Vrinda A , pushed by root root

Feedback app

 2019-09-26 04:55:06 Tree
[73c517] by Vrinda A Vrinda A , pushed by root root

Feedback app

 2019-09-26 04:53:16 Tree
[cad898] by root root

Feedback app

 2019-09-25 17:26:19 Tree
[877e48] by root root

Added rating field

 2019-09-25 17:14:22 Tree
[9b9776] by Vrinda A Vrinda A

[FEATURE] Added ForgeFeedback app

- This app will let the user rate and review a project.

 2019-09-25 17:14:22 Tree

Discussion

  • Dave Brondsema

    Dave Brondsema - 2021-12-15

    Hi,

    The unsubscribe commit looks pretty good. Would you able to add a test for it? For example test_new_admin_subscriptions covers when an admin user is added. It'd be nice to have a similar sort of test for when an admin user is removed.

    For the ticket & commit message linking, unfortunately I don't think it is quite the right direction. It does a lot of lookups & processing, so can be slow on large projects and sites. Also it is specifically for ticket pages and git commits, but it would be nice to handle other commit types (Allura supports SVN and Hg too) and would be nice to have commits possibly show up on wiki pages or other things besides tickets.

    I'd recommend that ArtifactReference and/or Shortlink records be created when the commit is received instead. And then everywhere the existing related_artifacts macro is used (tickets, wiki pages, comment posts, etc) it will display the commit links alongside any other related links.

    Of course the challenge will be exactly how to create the right ArtifactReference and Shortlink records. And offhand I'm not remembering what ArtifactReference does and what Shortlink does, but I do know they are very closely related. I think add_artifacts is what is used currently to create those records (for existing things like tickets [#123] or [WikiPageName]) particularly with its call to find_shortlinks. But for commits I don't know if add_artifacts is called or not (maybe not since a Commit is not an Artifact, more on that in a bit). Commits do have repo_refresh.py where a lot of background processing of new commits happens, so that'd be a potentially good spot to add/update code. That file does create some ArtifactReference and Shortlink records already - I think so that a ticket or comment or page can reference the commit like [aef3af3] but that is the opposite of what you are trying to accomplish. Another factor to be aware of is that Commit does not inherit from Artifact like so many other things do, so that might be a problem. I don't know why it is not an Artifact, maybe it could be, or maybe some code could handle Commit a little special and it'd be ok.

    Sorry for the not all good response, but hope it is ok. If you want to work on the different approach like I suggested I'd be happy to keep giving feedback on it, but I realize it probably would be a big undertaking.

    -Dave

     

  • Dave Brondsema

    Dave Brondsema - 2022-03-07
    • Status: open --> rejected
     

Log in to post a comment.