On /p/test/admin/tools, click the Options button under Discussion opens a new dialog, however clicking the Cancel link beside the Save button does not close the dialog window.
Discussion
Anonymous
-
2011-05-26
Originally by: algorithms
status: open --> in-progress
assigned_to: Wayne Witzel III
size: 2 --> 2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2011-05-26
Originally by: algorithms
status: in-progress --> code-review
assigned_to: Wayne Witzel III --> Rick Copéland
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2011-05-26
Originally by: algorithms
forge:ww/1433 @ git.code.sf.net/p/allura/git (NOTE: This is on the public repo)
Testing
Navigate to /p/test/admin/tools
Click the Options link under the Discussion heading.
You will now notice a Cancel button, instead of old Cancel a tag.
Click the Cancel button, lightbox_me dialog and overlay should be dismissed.
Follow the same set of instructions for the Options link under the Wiki heading.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Stylistically, I think we'd settled on making the cancel action be either a link or a graphical (x) (as in the top-right corner). Also, I've heard bad things about using live() performance-wise, so I'd like to avoid that if possible.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2011-06-01
Originally by: algorithms
Changed made based on code review. Switched live to delegate and reverted buttons back to a tags with a return false. Also switched the link's href to be javascript: void(0); instead of an empty hash to prevent the action from sending the user to the top of the page.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2011-06-01
Originally by: algorithms
status: in-progress --> code-review
assigned_to: Wayne Witzel III --> Rick Copéland
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Looks good. I did change the javascript:void(0) back to # since you don't need the javascript: href when you're returning false from the onclick event handler.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Originally by: algorithms
Originally by: algorithms
Originally by: algorithms
forge:ww/1433 @ git.code.sf.net/p/allura/git (NOTE: This is on the public repo)
Testing
Navigate to /p/test/admin/tools
Click the Options link under the Discussion heading.
You will now notice a Cancel button, instead of old Cancel a tag.
Click the Cancel button, lightbox_me dialog and overlay should be dismissed.
Follow the same set of instructions for the Options link under the Wiki heading.
Stylistically, I think we'd settled on making the cancel action be either a link or a graphical (x) (as in the top-right corner). Also, I've heard bad things about using live() performance-wise, so I'd like to avoid that if possible.
Originally by: algorithms
Changed made based on code review. Switched live to delegate and reverted buttons back to a tags with a return false. Also switched the link's href to be javascript: void(0); instead of an empty hash to prevent the action from sending the user to the top of the page.
Originally by: algorithms
Looks good. I did change the javascript:void(0) back to # since you don't need the javascript: href when you're returning false from the onclick event handler.