#1549 Discussion Thread moderation is broken

v1.0.0
closed
sf-4 (350)
Forum
nobody
2015-08-20
2011-02-23
No

This came up with [#1546]. There, project somehow managed to have Announcement flag set on a thread, which triggered error on display. However, further investigation showed that it doesn't really seem to be possible to set such a flag on a thread in current UI, because of:

  1. Bad UI layout of thread actions (see screenshot) https://sourceforge.net/p/allura/discussion/general/thread/8dcaf833/
  2. Wrongly tested condition (always false) for checking if thread moderation action should be shown
  3. Broken thread moderation widget which causes exception in EW on render
1 Attachments

Related

Tickets: #1546
Tickets: #1550
Tickets: #1560

Discussion

  • Paul Sokolovsky

    Paul Sokolovsky - 2011-02-23
    • Description has changed:

    Diff:

    --- old 
    +++ new 
    @@ -1,6 +1,6 @@
     This came up with [#1546]. There, project somehow managed to have Announcement flag set on a thread, which triggered error on display. However, further investigation showed that it doesn't really seem to be possible to set such a flag on a thread in current UI, because of:
    
    - * Bad UI layout of thread actions (see screenshot)
    + * Bad UI layout of thread actions (see screenshot) https://sourceforge.net/p/allura/discussion/general/thread/8dcaf833/
      * Wrongly tested condition (always false) for checking if thread moderation action should be shown
      * Broken thread moderation widget which causes exception in EW on render
      * ...
    
     

    Related

    Tickets: #1546

  • Dave Brondsema

    Dave Brondsema - 2011-02-23
    • milestone: limbo --> mar-03
     
  • Paul Sokolovsky

    Paul Sokolovsky - 2011-02-23

    1 & 3 are now fixed in ps/1549. 2 is related to some issues with EasyWidget widgets, sent email to Rick asking for suggestion how to resolve them.

    • status: in-progress --> code-review
    • assigned_to: Paul Sokolovsky --> Jenny Steele
     
  • Paul Sokolovsky

    Paul Sokolovsky - 2011-02-23
    • Description has changed:

    Diff:

    --- old 
    +++ new 
    @@ -1,6 +1,5 @@
     This came up with [#1546]. There, project somehow managed to have Announcement flag set on a thread, which triggered error on display. However, further investigation showed that it doesn't really seem to be possible to set such a flag on a thread in current UI, because of:
    
    - * Bad UI layout of thread actions (see screenshot) https://sourceforge.net/p/allura/discussion/general/thread/8dcaf833/
    - * Wrongly tested condition (always false) for checking if thread moderation action should be shown
    - * Broken thread moderation widget which causes exception in EW on render
    - * ...
    +1. Bad UI layout of thread actions (see screenshot) https://sourceforge.net/p/allura/discussion/general/thread/8dcaf833/
    +1. Wrongly tested condition (always false) for checking if thread moderation action should be shown
    +1. Broken thread moderation widget which causes exception in EW on render
    
     

    Related

    Tickets: #1546

  • Paul Sokolovsky

    Paul Sokolovsky - 2011-02-23

    Jenny, I'd appreciate your review of what's currently done.

     
  • Dave Brondsema

    Dave Brondsema - 2011-02-23
    • milestone: mar-03 --> feb-21
     
  • Jenny Steele

    Jenny Steele - 2011-02-23
    • assigned_to: Jenny Steele --> Paul Sokolovsky
    • milestone: feb-24 --> mar-03
     
  • Jenny Steele

    Jenny Steele - 2011-02-23

    Looks good

     
  • Dave Brondsema

    Dave Brondsema - 2011-02-23
    • milestone: mar-03 --> feb-24
     
  • Paul Sokolovsky

    Paul Sokolovsky - 2011-02-25

    Jenny, can you make a final look-over at this? Beyond what you already looked at, this added functional tests for thread moderation, and then fixed validation errors these tests uncovered. I also have corresponding changes to sftheme's *.scss file (will commit them togetether with merging this).

     
  • Paul Sokolovsky

    Paul Sokolovsky - 2011-02-25
    • assigned_to: Paul Sokolovsky --> Jenny Steele
    • size: 4 --> 4
     
  • Paul Sokolovsky

    Paul Sokolovsky - 2011-02-25

    Merged to dev.

     
  • Paul Sokolovsky

    Paul Sokolovsky - 2011-02-25
    • status: code-review --> closed
    • assigned_to: Jenny Steele --> Paul Sokolovsky
     

Log in to post a comment.