#1568 Correct use of name/value attributes for project registration

v1.0.0
closed
sf-4 (350)
Other
nobody
2015-08-20
2011-02-25
Kyle Adams
No

Right now the project registration form renders the checkboxes like so:

<input type="checkbox" name="Tickets">

Checkboxes that are logically grouped should all have the same name attribute while having different value attributes:

<input type="checkbox" name="tools" value="Tickets">

This ticket compliments [#1567] and should probably be implemented at the same time, as it's cleaner when there's just one checkbox for an SCM tool rather than checkboxes for each SCM.

Related

Tickets: #1567

Discussion

  • Mark Ramm - 2011-08-18
    • milestone: limbo --> aug-26
     
  • Dave Brondsema

    Dave Brondsema - 2011-08-19
    • size: --> 1
     
  • Jenny Steele - 2011-08-19
    • status: open --> in-progress
    • assigned_to: Jenny Steele
     
  • Jenny Steele - 2011-08-23

    Code is on allura and forge-classic js/1568. This isn't actually working yet, but I'm sending this to you for your thoughts. Do you think I'm using EW the right way here? I have the form mostly working how I'd like (I need to make the selected based on form value, not hardcoded, for instance), but the validation doesn't seem to be right. When I submit the form with multiple checkboxes checked, I only see the value of the last one checked in the controller (the log message in project.py). I see we haven't ever used CheckboxSet in allura and the test in ew doesn't actually test validation, is it possible this hasn't ever worked right? Or maybe I am using it wrong and need to try a different approach?

     
  • Jenny Steele - 2011-08-23
    • status: in-progress --> code-review
    • assigned_to: Jenny Steele --> Rick Copeland ☕
    • size: 1 --> 4
     
  • Rick Copeland - 2011-09-09

    The problem was a bad interaction between our variabledecode filter and antispam filter. I pushed a fix to your branch and send the ticket back to you :)

     
  • Rick Copeland - 2011-09-09
    • status: code-review --> in-progress
    • assigned_to: Rick Copeland ☕ --> Jenny Steele
     
  • Jenny Steele - 2011-09-14

    Ok, the form should work now. To test, make sure you can register a project with whatever tools you select and the html looks like described above.

     
  • Jenny Steele - 2011-09-14
    • status: in-progress --> code-review
    • assigned_to: Jenny Steele --> Rick Copeland ☕
     
  • Rick Copeland - 2011-09-14
    • status: code-review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2011-09-19
    • milestone: forge-sept-30 --> forge-sep-16
     

Log in to post a comment.