#1608 Fix mail None errors

v1.0.0
closed
sf-4 (350)
General
nobody
2015-08-20
2011-03-02
No

These errors are occurring somewhat often:

Module forgemail.reactors.common_react:128 in send_email
<<          data['message_id'],
               data.get('in_reply_to', None),
               multi_msg)
           smtp_client.sendmail(
               addrs_plain,
>>  multi_msg)
Module forgemail.lib.util:159 in sendmail
<<                  config.return_path,
                       map(_parse_smtp_addr, addrs),
                       content)

           def _connect(self):
>>  content)
Module smtplib:709 in sendmail
<<              # the server refused all our recipients
                   self.rset()
                   raise SMTPRecipientsRefused(senderrs)
               (code,resp) = self.data(msg)
               if code != 250:
>>  raise SMTPRecipientsRefused(senderrs)
SMTPRecipientsRefused: {'@users.sf.net': (501, '<@users.sf.net>: no local part')}
app: None
exchange: 'audit'
key: u'forgemail.send_email'
message: ...
project: u'flexunit'
user: u'vinayksh'

and

Module forgemail.reactors.common_react:98 in send_email
<<              addrs_plain.append(addr)
               else:
                   user = M.User.query.get(_id=ObjectId(addr))
                   if not user:
                       log.warning('Cannot find user with ID %s', addr)
>>  user = M.User.query.get(_id=ObjectId(addr))
Module bson.objectid:76 in __init__
<<              self.__generate()
               else:
                   self.__validate(oid)

           @classmethod
>>  self.__validate(oid)
Module bson.objectid:160 in __validate
<<                      raise InvalidId("%s is not a valid ObjectId" % oid)
                   else:
                       raise InvalidId("%s is not a valid ObjectId" % oid)
               else:
                   raise TypeError("id must be an instance of (str, ObjectId), "
>>  raise InvalidId("%s is not a valid ObjectId" % oid)
InvalidId: None is not a valid ObjectId
app: None
exchange: 'audit'
key: u'forgemail.send_email'
message: ...
project: u'necessitas'
user: u'daminetreg'

Discussion

  • Dave Brondsema

    Dave Brondsema - 2011-03-03

    the first error I believe is due to our openid-only user (but I could be wrong)
    not sure on the 2nd
    though it's easy enough to trap-n-log (though suboptimal)

     
  • Dave Brondsema

    Dave Brondsema - 2011-03-03
    • size: --> 4
     
  • Mark Ramm - 2011-03-03
    • milestone: mar-10 --> mar-17
     
  • Rick Copeland - 2011-03-09
    • status: open --> in-progress
    • assigned_to: Rick Copéland
     
  • Rick Copeland - 2011-03-09
    • status: in-progress --> code-review
     
  • Rick Copeland - 2011-03-09
    • status: code-review --> closed

    • milestone: mar-17 --> mar-10

     

Log in to post a comment.