Originally created by: darthflatus
Originally owned by: darthflatus
There should be a code review feature in place, however this usually requires a change in workflow with ticket tracking and the powers that be need to decide the location(s) that it is required from and to. i.e. if I create a jg/codereview branch and then request a pull for X commits then it may just make sense to (once accepted) be put into dev.
To avoid NIH, I would appreciate any and all suggestions for known code review tools. Additionally a set of minimal (required) and optimal (good to have) specs and features would be good too.
Some ideas off the top of my head for features (not ranked) are:
- ticket and code review tie in... but not in a way that there is spammy (how in the heck do you spell that, lol) duplication of info for things like comments and such. Perhaps just ticket #(s) (and comment #(s)) between the two, thus preserving some sanity between code review comments and subsequent fix comments.
- graphs are purty
- code review should allow for easy reference of code outside of copy-and-paste WITH annotation (personally I call this a MUST HAVE)
- plans (hooks?) for use with any intended 'one ring to rule them all' tie in of all artifacts together. i.e. a rejected feature due to code review rejection and/or ticket status change could later be (easily) dug up... this is great for ideas or tools ahead of their time ;)
- integration with any stat/graph tool like [#871] (as I said... graphs are purty)