#1779 Option to poll for tasks, and not need rabbitmq

v1.0.0
closed
Rick Copeland
sf-1 (616)
General
nobody
2015-08-20
2011-03-22
Dave Brondsema
No

It would help local development and the basic installation process if amqp was not needed.

Provide an option to do polling every 10s or so (configurable). And a config option so it's optional to use amqp for notifications that there are new MonQTasks.

Also, must update README.markdown with these changes.

Related

Tickets: #1648

Discussion

  • Dave Brondsema

    Dave Brondsema - 2011-03-23
    • Description has changed:

    Diff:

    --- old 
+++ new 
@@ -1,7 +1,5 @@
 It would help local development and the basic installation process if amqp was not needed.

-Provide an option to do polling every 10s or so, instead of using amqp for notifications that there are new MonQTasks.
-
-g.post_event would be a no-op, and @event_handler functions would never get called.  That should be fine for non-prod environments.
+Provide an option to do polling every 10s or so (configurable).  And a config option so it's optional to use amqp for notifications that there are new MonQTasks.

 Also, must update README.markdown with these changes.
     

  • Rick Copeland - 2011-03-23
    • status: open --> in-progress
    • assigned_to: Rick Copéland
     

  • Rick Copeland - 2011-03-23

    Ready for review on rc/1779

    To QA: see if setup-app still makes the taskd server do stuff. The development.ini here disables rabbitmq use by default.

    • milestone: backlog --> mar-24
     

  • Rick Copeland - 2011-03-23
    • status: in-progress --> code-review
    • assigned_to: Rick Copéland --> Dave Brondsema
    • size: --> 1
     

  • Dave Brondsema

    Dave Brondsema - 2011-03-25
    • status: code-review --> in-progress
    • assigned_to: Dave Brondsema --> Rick Copéland
     

  • Dave Brondsema

    Dave Brondsema - 2011-03-25
    • the functionality is fine, but:
    • shouldn't we have a new test for polling?
    • we need the README install docs updated, explaining how to skip the optional rabbitmq stuff
      • probably should move amqplib and kombu from requirements-common.txt to requirements.txt
     

  • Rick Copeland - 2011-03-25

    Testing for polling is probably a really bad idea as it will slow things down.

    The README.markdown has already been updated (sections regarding rabbitmq are marked 'optional', meaning if you don't want rabbitmq, don't do them).

    What are the implications of moving amqplib and kombu to requirements.txt? I never understood the split....

     

  • Dave Brondsema

    Dave Brondsema - 2011-03-25
    • status: in-progress --> closed
     

Log in to post a comment.