#1885 diffs not showing up for files not known to be displayable

v1.0.0
closed
sf-2 (994)
SCM
nobody
2015-08-20
2011-04-04
Wolf
No

We're kind of finicky about what files we'll try to display or not, and somehow this has carried over to our repo diffs. If the underlying file is not known to be displayable, we show the diff link, but it leads to a dead-end where you can download the file in question --- but not see the diff.

Probably we need to (a) rethink our ideas about what files are displayable; and (b) assume a diff is always displayable.

Related

Tickets: #1917

Discussion

  • Dave Brondsema

    Dave Brondsema - 2011-04-07
    • milestone: limbo --> backlog
     
  • Dave Brondsema

    Dave Brondsema - 2011-04-07
    • size: --> 2
     
  • Dave Brondsema

    Dave Brondsema - 2011-04-07

    b)

     
  • Jenny Steele - 2011-04-11
    • status: open --> in-progress
    • assigned_to: Jenny Steele
    • component: General --> SCM
     
  • Jenny Steele - 2011-04-13
    • status: in-progress --> code-review
    • assigned_to: Jenny Steele --> Rick Copéland
     
  • Jenny Steele - 2011-04-13

    Update is on js/1885

     
  • Rick Copeland - 2011-04-14
    • status: code-review --> closed
     
  • Rick Copeland - 2011-04-14

    Looks good

     

Log in to post a comment.