Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, deshani, dill0wn, and 10 others

#1913 Add screenshots & captions interface

Milestone: v1.0.0

Status: closed

Owner: Dave Brondsema

Labels: sf-4 (350)

Component: General

Reviewer: nobody

Updated: 2015-08-20

Created: 2011-04-07

Creator: Dave Brondsema

Private: No

There is already some screenshot code in Allura/allura/ext/admin/admin_main.py and Allura/allura/controllers/project.py

Also, update forge-classic hook to update gutenberg.

Need to dig into SFX some, to see the constraints (image dimensions, image file size, number of images, caption length, etc) and decide which to keep.

Discussion

Dave Brondsema - 2011-04-21

size: --> 4
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jenny Steele - 2011-04-21

status: open --> in-progress

assigned_to: Jenny Steele
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jenny Steele - 2011-04-25

Updates are on allura and forge classic js/1913. To test:

1) Create a project
2) Go to /p/xyz/admin/screenshots and add a screenshot
3) Confirm screenshot shows up on /p/xyz/home/

Also make sure delete and caption edit work. If you try to add more than 6 screenshots it should show you an error message saying you can't have more than 6.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jenny Steele - 2011-04-25

status: in-progress --> code-review

assigned_to: Jenny Steele --> Wolf
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Wolf - 2011-04-26

merged to forge:dev @ [f15b58f], forge-classic:dev @ [d6725a7]

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Wolf - 2011-04-26

status: code-review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-04-26

I was just taking a look at this since it's a fairly big new features. Two things:

don't we need some permission checks for add_/edit_/delete_screenshot ?

is 75x50 non-square a reasonable size for thumbnails? that is the current planned size for the summary page redesign. It would be nice if they matched. But I don't want to do something that doesn't make sense for other Allura deployments.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-04-26

status: closed --> open

assigned_to: Wolf --> Jenny Steele
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jenny Steele - 2011-04-26

status: open --> code-review

assigned_to: Jenny Steele --> Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jenny Steele - 2011-04-26

I've added the permission checks in. Please add a new ticket for the thumbnail size once we get a final design for the project summary page.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-04-26

status: code-review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.