#1937 Comments' "Link" link is wrong

v1.0.0
closed
nobody
42cc (432)
General
Dave Brondsema
2015-08-20
2011-04-12
Dave Brondsema
No

Alongside each comment on tickets, forums, etc, there is a "link" link. When you click on it, a textbox opens with text like:

<a href="/p/allura/tickets/1/?limit=10&amp;page=0#e11e">#1 discussion</a>

It should be a textbox with this text, and the text should be pre-selected. Omit page & limit param if page 0:

http://sourceforge.net/p/allura/tickets/1/#e11e

Related

Tickets: #1937

Discussion

  • Dave Brondsema

    Dave Brondsema - 2012-07-02
    • labels: --> 42cc
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,15 +1,13 @@
-Instead of a textbox with:
+Alongside each comment on tickets, forums, etc, there is a "link" link.  When you click on it, a textbox opens with text like:

 ~~~~
 :::text
 <a href="/p/allura/tickets/1/?limit=10&amp;page=0#e11e">#1 discussion</a>
 ~~~~

-It should be a textbox with (adding page param if needed):
+It should be a textbox with this text, and the text should be pre-selected.  Omit page & limit param if page 0:

 ~~~~
 :::text
-http://sf.net/p/allura/tickets/1/#e11e
+http://sourceforge.net/p/allura/tickets/1/#e11e
 ~~~~
-
-And be pre-selected.
     

  • Yaroslav Luzin - 2012-07-03

    created #98: [#1937] Fix "link" link for comments on tickets, forum, etc (1cp)

    • status: open --> in-progress
     

    Related

    Tickets: #1937

  • Yaroslav Luzin - 2012-07-05

    closed #98, changes are in 42cc_1937

    • status: in-progress --> code-review
     

  • Dave Brondsema

    Dave Brondsema - 2012-07-05
    • status: code-review --> in-progress
     

  • Dave Brondsema

    Dave Brondsema - 2012-07-05

    The javascript to pre-select the URL isn't working. The rest is fine.

     

  • Yaroslav Luzin - 2012-07-06

    created #106: [#1937] Make sure that js works correctly (1cp)

     

    Related

    Tickets: #1937

  • Yaroslav Luzin - 2012-07-09

    closed #106, please check 42cc_1937

    • status: in-progress --> code-review
     

  • Dave Brondsema

    Dave Brondsema - 2012-07-09
    • status: code-review --> closed
    • qa: Dave Brondsema
    • milestone: forge-backlog --> forge-jul-13
     

Log in to post a comment.