#2063 has_access() should act as expected, in a boolean context

v1.0.0
closed
sf-1 (616)
General
nobody
2015-08-20
2011-05-03
No

security.has_access() returns a predicate aka callable aka function. So has_access(...)() must be used. If you accidentally use has_access(...) in an "if" it'll be evaluated as true.

We could make has_access() return an object with a __call__ method (for predicate context) and a __nonzero__ method (for boolean context).

Discussion

  • Dave Brondsema

    Dave Brondsema - 2011-05-05
    • size: --> 1
     
    • status: open --> in-progress
    • assigned_to: Tim Van Steenburgh
     
    • status: in-progress --> code-review
    • assigned_to: Tim Van Steenburgh --> Rick Copéland
     
  • tv/2063

     
  • Rick Copeland - 2011-05-09
    • status: code-review --> closed
     
  • Rick Copeland - 2011-05-09

    Looks good. Merged to dev.

     

Log in to post a comment.