Apache Allura™ / Tickets / #2165 QA 1540 & 2020

Dave Brondsema - 2011-06-29

milestone: jun-24 --> jul-01
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mark Ramm - 2011-07-01

milestone: jul-08 --> jul-15
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-07-19

assigned_to: Dave Brondsema --> nobody

size: 0 --> 2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-07-19

I don't have to be sitting on this - someone else could take it, since dstats is a high priority for me now

status: code-review --> open
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-07-25

status: open --> in-progress

assigned_to: Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-07-25

are there tests that cover the new commit shortlinks? I can't find any new tests

also should have tests for the svn-specific logic (e.g. link notation, refresh_commit_info which has typos on lines 243 & 268)

After locally fixing those typos I got this (while refreshing an svn repo):

Traceback (most recent call last): File "../scripts/refresh-all-repos.py", line 67, in main c.app.repo.refresh(options.all, notify=options.notify) File "/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/model/repository.py", line 306, in refresh refresh_repo(self, all_commits, notify) File "/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/model/repo_refresh.py", line 52, in refresh_repo cache = refresh_commit_trees(ci, cache) File "/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/model/repo_refresh.py", line 72, in refresh_commit_trees tree_ids = list(trees(ci.tree_id, cache)))) File "/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/model/repo_refresh.py", line 214, in trees entries = [ o.id for o in t.tree_ids ] AttributeError: 'NoneType' object has no attribute 'tree_ids'

And from taskd after committing a new SVN commit:

File "/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/model/monq_model.py", line 219, in __call__ self.result = func(*self.args, **self.kwargs) File "/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/tasks/repo_tasks.py", line 35, in refresh c.app.repo.refresh() File "/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/model/repository.py", line 306, in refresh refresh_repo(self, all_commits, notify) File "/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/model/repo_refresh.py", line 66, in refresh_repo send_notifications(commit_ids) TypeError: send_notifications() takes exactly 2 arguments (1 given)

Lastly, after that error got this (so not necessarily an error unto its own) when visiting a wiki page that that had commit references in it:

~~~~
[Mon Jul 25 19:15:47 2011] [error] [client 127.0.0.1] File '/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/templates/jinja_master/lib.html', line 2 in template
[Mon Jul 25 19:15:47 2011] [error] [client 127.0.0.1] {% set related_artifacts = artifact.related_artifacts() %}
[Mon Jul 25 19:15:47 2011] [error] [client 127.0.0.1] File '/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/model/artifact.py', line 106 in related_artifacts
[Mon Jul 25 19:15:47 2011] [error] [client 127.0.0.1] ref = ArtifactReference.query.get(_id=ref_id)
... ming lines ...
[Mon Jul 25 19:13:45 2011] [error] [client 127.0.0.1] Invalid: <class 'ming.metadata.Document<artifact_reference="">'>:
[Mon Jul 25 19:13:45 2011] [error] [client 127.0.0.1] artifact_reference:cls:callura.model.repo
[Mon Jul 25 19:13:45 2011] [error] [client 127.0.0.1] Commit
[Mon Jul 25 19:13:45 2011] [error] [client 127.0.0.1] p1
[Mon Jul 25 19:13:45 2011] [error] [client 127.0.0.1] . is not a <class 'bson.binary.Binary'="">
~~~
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-07-25

status: in-progress --> open

assigned_to: Dave Brondsema --> Rick Copeland ☕
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-07-26

Oh, and use rc/2020-rebased. It is rebased and includes a few commits from me

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rick Copeland - 2011-07-29

status: open --> in-progress
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rick Copeland - 2011-08-03

status: in-progress --> code-review

assigned_to: Rick Copeland ☕ --> Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rick Copeland - 2011-08-03

Back at you with tests and several fixes discovered when adding tests

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-08-04

Many ForgeSVN/Hg/Git tests fail with NotImplementedError: $addToSet. I'm on Ming==0.2.2dev-20110720

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-08-04

status: code-review --> in-progress

assigned_to: Dave Brondsema --> Rick Copeland ☕
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rick Copeland - 2011-08-04

status: in-progress --> code-review

assigned_to: Rick Copeland ☕ --> Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rick Copeland - 2011-08-04

Version of Ming bumped

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-08-05

milestone: aug-12 --> aug-05
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-08-08

status: code-review --> in-progress

assigned_to: Dave Brondsema --> Rick Copeland ☕

milestone: aug-05 --> aug-12
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

If I put any artifact reference (e.g. [r1] or [2fcfb5e9c477675949426450cbe6240b6488e217]) in a page, that page 500s upon render:

File '/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/templates/jinja_master/lib.html', line 2 in template
  {% set related_artifacts = artifact.related_artifacts() %}
File '/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/model/artifact.py', line 106 in related_artifacts
  ref = ArtifactReference.query.get(_id=ref_id)
File '/var/local/env-allura/lib/python2.7/site-packages/ming/orm/mapper.py', line 226 in get
  return self.session.get(self.mapped_class, kwargs['_id'])
File '/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/lib/stats.py', line 57 in inner
  return func(*l, **kw)
File '/var/local/env-allura/lib/python2.7/site-packages/ming/orm/ormsession.py', line 105 in get
  result = self.find(cls, dict(_id=idvalue)).first()
File '/var/local/env-allura/lib/python2.7/site-packages/ming/orm/ormsession.py', line 294 in first
  return self.next()
File '/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/lib/stats.py', line 57 in inner
  return func(*l, **kw)
File '/var/local/env-allura/lib/python2.7/site-packages/ming/orm/ormsession.py', line 247 in next
  doc = self.ming_cursor.next()
File '/var/local/env-allura/lib/python2.7/site-packages/ming/base.py', line 61 in next
  strip_extra=self._strip_extra)
File '/var/local/env-allura/lib/python2.7/site-packages/ming/metadata.py', line 324 in make
  return cls.m.make(data, allow_extra=allow_extra, strip_extra=strip_extra)
File '/var/local/env-allura/lib/python2.7/site-packages/ming/metadata.py', line 238 in make
  data, allow_extra=allow_extra, strip_extra=strip_extra)
File '/var/local/env-allura/lib/python2.7/site-packages/ming/schema.py', line 329 in validate
  return super(Document, self).validate(value, **kw)
File '/var/local/env-allura/lib/python2.7/site-packages/ming/schema.py', line 229 in validate
  return self._validate(value, **kw)
File '/var/local/env-allura/lib/python2.7/site-packages/ming/schema.py', line 349 in _validate
  result.update(super(Document, self)._validate(d, allow_extra, strip_extra))
File '/var/local/env-allura/lib/python2.7/site-packages/ming/schema.py', line 297 in _validate
  raise Invalid(msg, d, None, error_dict=error_dict)
Invalid: <class 'ming.metadata.Document<artifact_reference>'>:
    artifact_reference:cls:callura.model.repo
    Commit
    p1
    . is not a <class 'bson.binary.Binary'>

and allura.log shows this (not sure if relevant):

15:33:22,459 WARNI [allura.model.index] Ambiguous link to r1
15:33:22,459 WARNI [allura.model.index] ... [testscm:code:r1] -> allura.model.repo.Commit#4e3ff8219c10407d0b000046:1
15:33:22,461 WARNI [allura.model.index] ... [testscm:code:r1] -> allura.model.repo.Commit#4e3ff8219c10407d0b000046:1
15:33:22,462 WARNI [allura.model.index] ... [testscm:code:r1] -> allura.model.repo.Commit#4e3ff8219c10407d0b000046:1
15:33:22,463 WARNI [allura.model.index] ... [testscm:code-svn2:r1] -> allura.model.repo.Commit#4e3fff5f9c10403d19000021:1

Rick Copeland - 2011-08-08

status: in-progress --> code-review

assigned_to: Rick Copeland ☕ --> Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rick Copeland - 2011-08-08

Update on rc/2020

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

I'm getting another error trying the same thing (commit references). Maybe we should have a test that exercises this?

[Mon Aug 08 21:06:00 2011] [error] [client 127.0.0.1] File '/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/templates/widgets/post_widget.html', line 22 in top-level template code
[Mon Aug 08 21:06:00 2011] [error] [client 127.0.0.1]   {{lib.related_artifacts(value)}}
[Mon Aug 08 21:06:00 2011] [error] [client 127.0.0.1] File '/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/templates/jinja_master/lib.html', line 7 in template
[Mon Aug 08 21:06:00 2011] [error] [client 127.0.0.1]   <a href="{{related.url()}}">{{related.type_s}}: {{related.link_text()}}</a><br>
[Mon Aug 08 21:06:00 2011] [error] [client 127.0.0.1] File '/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/model/repo.py', line 179 in url
[Mon Aug 08 21:06:00 2011] [error] [client 127.0.0.1]   return self.repo.url_for_commit(self.legacy)
[Mon Aug 08 21:06:00 2011] [error] [client 127.0.0.1] AttributeError: 'NoneType' object has no attribute 'url_for_commit'

Dave Brondsema - 2011-08-08

status: code-review --> in-progress

assigned_to: Dave Brondsema --> Rick Copeland ☕
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rick Copeland - 2011-10-05

Now with a test, and I was unable to duplicate the error you were getting.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rick Copeland - 2011-10-05

status: open --> code-review

assigned_to: Rick Copeland ☕ --> Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2011-10-06

To reproduce:

set scm.new_refresh = true

refresh a repo with commits

add a commit ref to an artifact whose display shows related artifacts (e.g. a ticket)

it errors when trying to render the related artifact links

P.S. can the new test assert rather than just print?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Apache Allura™

Forge software for hosting software projects

Milestone

Searches

Help

#2165 QA 1540 & 2020

Related

Discussion