In the fork, the sidebar menu doesn't even appear (this is where we'd normally display the merge request button). In the parent repo, there doesn't seem to be a way to see a list of forks.
To test, fork a git and hg repo to another project. On the clone, the sidebar should be present and contain "Clone of" with a link to the upstream repo. After the fork, the sidebar of the upstream repo should contain a list of Forks, which should now contain a link to the new clone.
Also added functional tests for this, for git and hg.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
we should comment-out the merge request button until that is fixed
I think it'd look nicer to split project name & repo name onto their own lines, within each <li>
do we need an index for the self.query.find({'upstream_repo.name': self.url()}) query? We only have 7k git repos and 616 hg repos so far, but it has to scan them and that won't perform so well later.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Made the suggested changes. On the clone/fork buttons, the route I took is a bit different than what you suggested. I like it b/c it doesn't waste vertical space in the event that everything fits on one line. If you don't like it, however, I'll be happy to revisit.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
forge:tv/2380
To test, fork a git and hg repo to another project. On the clone, the sidebar should be present and contain "Clone of" with a link to the upstream repo. After the fork, the sidebar of the upstream repo should contain a list of Forks, which should now contain a link to the new clone.
Also added functional tests for this, for git and hg.
Looks good, a few things:
<li>self.query.find({'upstream_repo.name': self.url()})query? We only have 7k git repos and 616 hg repos so far, but it has to scan them and that won't perform so well later.Made the suggested changes. On the clone/fork buttons, the route I took is a bit different than what you suggested. I like it b/c it doesn't waste vertical space in the event that everything fits on one line. If you don't like it, however, I'll be happy to revisit.