#2467 Allura shouldn't depend on zeromq

v1.0.0
closed
sf-2 (994)
General
nobody
2015-08-20
2011-07-16
Anonymous
No

Originally created by: takedap

I ran into an issue when installing allura to test environment following the document at https://sourceforge.net/p/allura/git/ci/a3d6d91c61bfcf84c1a114867cbaf8d1a485b2ef/tree/#readme

I got an error "fatal error: event.h: No such file or directory" and an quick question to uncle google revealed that I was missing package libevent-dev. The distribution is an fresh ubuntu 10.10 on VirtualBox as the readme suggests and atleast based on my test everyone who'll follow the guide will run onto this.

Discussion

  • Anonymous - 2011-07-19

    Originally by: takedap

    Additionally, on my Ubuntu Maverick -setup I also had to install zeromq and it's requirements from PPA https://launchpad.net/~chris-lea/+archive/zeromq to get everything running.

     
  • Dave Brondsema

    Dave Brondsema - 2011-07-19
    • milestone: limbo --> jul-29
     
  • Dave Brondsema

    Dave Brondsema - 2011-07-19

    We probably can, and should, make zeromq optional.

     
  • Dave Brondsema

    Dave Brondsema - 2011-07-22
    • summary: Missing -dev package on installation instructions --> Allura shouldn't depend on zeromq
    • size: --> 2
     
  • Anonymous - 2011-08-03

    Originally by: algorithms

    • status: open --> in-progress
    • assigned_to: Wayne Witzel III
     
  • Anonymous - 2011-08-11

    Originally by: algorithms

    Updated the README and tweaked the forge project to not need 0mq to be installed when deploying under Ubuntu.

    For testing, I created a new VirtualBox Ubuntu 10.10 installation and followed the Installation / Setup guide and ensured I was not asked to install 0mq.

     
  • Anonymous - 2011-08-18

    Originally by: algorithms

    • status: in-progress --> code-review
    • assigned_to: Wayne Witzel III --> Dave Brondsema

    forge:ww/2467

     
  • Dave Brondsema

    Dave Brondsema - 2011-08-19

    gevent and greenlet requirements can be moved out of requirements-common.txt also. I'm also thinking about a config option rather than an import guard. If for some reason the import failed, but you had it configured to use zarkov, then you'd get the importerror instead of it being silently swallowed. I'm not 100%, but that's how I'd lean

     
  • Dave Brondsema

    Dave Brondsema - 2011-08-19
    • status: code-review --> in-progress
    • assigned_to: Dave Brondsema --> Wayne Witzel III
     
  • Anonymous - 2011-08-19

    Originally by: algorithms

    Moved gevent and greenlet. Added an import check to the middleware based on if zarkov.host is set in the ini file or not and add some feedback for the user if they have the zarkov.host define, but do not have the libraries installed.

    TESTING:
    Try to setup a new Allura project on a clean virtualenv, pip install requirements-dev/common should not result in lib-event or 0mq being required. Set a zarkov.host in the ini file and try to paster launch the project, you should get an ImportError with a nice message explaining why.

     
  • Anonymous - 2011-08-19

    Originally by: algorithms

    • status: in-progress --> code-review
    • assigned_to: Wayne Witzel III --> Dave Brondsema
     
  • Anonymous - 2011-08-19

    Originally by: algorithms

    implementation justifications

    make_app isn't called during the imports of app_globals , this is why the check was placed in the middleware after load_environment is called to ensure config values from the ini are set.

    moving the import inside the zarkov_event method also didn't work because the ImportError would not happen until after the user called zarkov_event resulting a unhandled exception and 500 while the application was running.

     
  • Dave Brondsema

    Dave Brondsema - 2011-08-23

    Take, this is complete in our internal 'dev' branch and will pushed to the public repo within a few days

     
  • Dave Brondsema

    Dave Brondsema - 2011-08-23
    • status: code-review --> closed
     

Log in to post a comment.