#2544 500 error accessing deleted thread

v1.0.0
closed
Tim Van Steenburgh
sf-2 (994)
Tracker
nobody
2015-08-20
2011-08-01
Dave Brondsema
No

http://sourceforg.net/p/allura/discussion/general/thread/cbb6205c/ (which is a deleted thread) generates a 500 error:

[Sun Jul 31 13:22:24 2011] [error] [client 127.0.0.1] File '/var/local/allura/Allura/allura/controllers/discuss.py', line 146 in _check_security
[Sun Jul 31 13:22:24 2011] [error] [client 127.0.0.1]   require_access(self.thread, 'read')
[Sun Jul 31 13:22:24 2011] [error] [client 127.0.0.1] File '/var/local/allura/Allura/allura/lib/security.py', line 301 in require_access
[Sun Jul 31 13:22:24 2011] [error] [client 127.0.0.1]   return require(predicate, message='%s access required' % permission.capitalize())
[Sun Jul 31 13:22:24 2011] [error] [client 127.0.0.1] File '/var/local/allura/Allura/allura/lib/security.py', line 288 in require
[Sun Jul 31 13:22:24 2011] [error] [client 127.0.0.1]   if predicate(): return
[Sun Jul 31 13:22:24 2011] [error] [client 127.0.0.1] File '/var/local/allura/Allura/allura/lib/utils.py', line 295 in __call__
[Sun Jul 31 13:22:24 2011] [error] [client 127.0.0.1]   return self.callable(*args, **kw)
[Sun Jul 31 13:22:24 2011] [error] [client 127.0.0.1] File '/var/local/allura/Allura/allura/lib/security.py', line 254 in predicate
[Sun Jul 31 13:22:24 2011] [error] [client 127.0.0.1]   for ace in obj.acl:
[Sun Jul 31 13:22:24 2011] [error] [client 127.0.0.1] AttributeError: 'NoneType' object has no attribute 'acl'

Discussion

  • Dave Brondsema

    Dave Brondsema - 2011-08-05
    • size: --> 2
     

  • Tim Van Steenburgh - 2011-08-05
    • status: open --> in-progress
    • assigned_to: Tim Van Steenburgh
     

  • Tim Van Steenburgh - 2011-08-05

    forge:tv/2544

    Added functional test. To test manually, create a new topic on an allura project discussion forum. Copy the URL for the thread. As an admin, go to Moderate and delete the thread by deleting all of its posts. Now paste the URL for the thread and confirm you get a 404 instead of 500.

    • status: in-progress --> code-review
    • assigned_to: Tim Van Steenburgh --> Wayne Witzel III
     

  • Anonymous - 2011-08-09

    Originally by: algorithms

    code looks good, tests pass, merged to dev

    (env-allura)[root@wwitzel-9029 ForgeDiscussion]# nosetests
    .......................................

    Ran 39 tests in 145.898s

    OK

    • status: code-review --> closed
    • assigned_to: Wayne Witzel III --> Tim Van Steenburgh
     

Log in to post a comment.