#2598 Wiki macro for best-download

v1.0.0
closed
Wiki
nobody
2015-08-20
2011-08-11
No

Resurrect the code for showing the best-download button from the old 'Home' tool (uses JS, from sfpy) and make it a macro, probably [[download_button]]

Discussion

  • Mark Ramm

    Mark Ramm - 2011-08-11
    • milestone: backlog --> aug-19
     
  • Dave Brondsema

    Dave Brondsema - 2011-08-12
    • size: --> 1
     
  • Jenny Steele

    Jenny Steele - 2011-08-12
    • status: open --> in-progress
    • assigned_to: Jenny Steele
     
  • Jenny Steele

    Jenny Steele - 2011-08-16

    Code is on allura js/2598. To test, add this to any markdown area: [[download_button]]. Make sure you see the data being pulled from a url like https://sf-jsteele-5015.sb.sf.net/projects/zzz/best_release.html in firebug. This is expected to 404 and not show a button if your project doesn't have any download files associated with it.

     
  • Jenny Steele

    Jenny Steele - 2011-08-16
    • status: in-progress --> code-review
    • assigned_to: Jenny Steele --> Wayne Witzel III
     
  • Anonymous - 2011-08-18

    Originally by: algorithms

    macro works, code reads fine, missing a test

    Thought: instead of now showing anything when they use this, would it be a better UX to display a No Downloads button?

    • assigned_to: Wayne Witzel III --> Jenny Steele
     
  • Jenny Steele

    Jenny Steele - 2011-08-24
    • assigned_to: Jenny Steele --> Wayne Witzel III
     
  • Jenny Steele

    Jenny Steele - 2011-08-24

    I added a test. I did not change the behavior to say No Downloads, but I did add documentation for the macro which shows how to do it and explains that it won't show up if there aren't any downloads available.

     
  • Anonymous - 2011-08-25

    Originally by: algorithms

    Test looks good, documentation update is great, and the macro functions as intended on wiki pages. Nice job. Merged to dev.

    [root@h9v9029 Allura js/2598]# nosetests -x allura.tests.test_globals
    ....
    ----------------------------------------------------------------------
    Ran 4 tests in 9.547s
    
    OK
    
    • status: code-review --> closed
    • assigned_to: Wayne Witzel III --> Jenny Steele
     

Log in to post a comment.